chrome/common/extensions/message_bundle.cc - Issue 12319073: Delete the extensions i18n message map when extension unload is received.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/message_bundle.cc

Issue 12319073: Delete the extensions i18n message map when extension unload is received. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed to i18n_apitest and fixed up misc Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/i18n/i18n_apitest.cc ('K') | « chrome/common/extensions/message_bundle.h ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/message_bundle.cc

diff --git a/chrome/common/extensions/message_bundle.cc b/chrome/common/extensions/message_bundle.cc

index 0a71b3199259ed8ca516deec5b1b5974fdda9ac6..6dbbdfa2b19d60f69869d3d4147b0f6bc2e9d209 100644

--- a/chrome/common/extensions/message_bundle.cc

+++ b/chrome/common/extensions/message_bundle.cc

@@ -341,4 +341,7 @@ L10nMessagesMap* GetL10nMessagesMap(const std::string& extension_id) {

return NULL;

}

+void EraseL10nMessagesMap(const std::string& extension_id) {

+ g_extension_to_messages_map.Get().messages_map.erase(extension_id);

Devlin 2013/02/27 23:10:41 nit: Insert newline here.

Patrick Riordan 2013/03/01 17:29:22 Done.

} // namespace extensions

« chrome/browser/extensions/api/i18n/i18n_apitest.cc ('K') | « chrome/common/extensions/message_bundle.h ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | no next file with comments »