Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1231893006: Update ink splash to new animation system (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
mpcomplete, Matt Perry
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : less final #

Total comments: 3

Patch Set 3 : less final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M sky/sdk/lib/animation/animation_performance.dart View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/ink_well.dart View 6 chunks +40 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-09 21:41:36 UTC) #1
Matt Perry
LGTM https://codereview.chromium.org/1231893006/diff/20001/sky/sdk/lib/widgets/ink_well.dart File sky/sdk/lib/widgets/ink_well.dart (right): https://codereview.chromium.org/1231893006/diff/20001/sky/sdk/lib/widgets/ink_well.dart#newcode113 sky/sdk/lib/widgets/ink_well.dart:113: void _cancelSplash(int pointer) { This is never called
5 years, 5 months ago (2015-07-09 22:12:09 UTC) #3
abarth-chromium
https://codereview.chromium.org/1231893006/diff/20001/sky/sdk/lib/widgets/ink_well.dart File sky/sdk/lib/widgets/ink_well.dart (right): https://codereview.chromium.org/1231893006/diff/20001/sky/sdk/lib/widgets/ink_well.dart#newcode113 sky/sdk/lib/widgets/ink_well.dart:113: void _cancelSplash(int pointer) { On 2015/07/09 at 22:12:09, Matt ...
5 years, 5 months ago (2015-07-09 22:20:47 UTC) #4
Matt Perry
https://codereview.chromium.org/1231893006/diff/20001/sky/sdk/lib/widgets/ink_well.dart File sky/sdk/lib/widgets/ink_well.dart (right): https://codereview.chromium.org/1231893006/diff/20001/sky/sdk/lib/widgets/ink_well.dart#newcode113 sky/sdk/lib/widgets/ink_well.dart:113: void _cancelSplash(int pointer) { On 2015/07/09 22:20:46, abarth-chromium wrote: ...
5 years, 5 months ago (2015-07-09 22:21:28 UTC) #5
abarth-chromium
5 years, 5 months ago (2015-07-09 22:26:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ea31bbfb2c1b18aaf019688899f3a214811a5ddb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698