Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1231843002: Revert of Revert vector icon CLs. (Closed)

Created:
5 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 5 months ago
Reviewers:
CC:
chromium-reviews, tfarina, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_aide_oobe_completion
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert vector icon CLs. (patchset #1 id:1 of https://codereview.chromium.org/1228923002/) Reason for revert: Reverting the revert - it turned out the failures weren't caused by the reverted CLs, but a bot configuration change happening at the same time: https://codereview.chromium.org/1212443005 Original issue's description: > Revert vector icon CLs. > > This reverts the following commits: > > ac1592c73bdd24eca2ea3e591e8f7b199627e6e7: "mandoline: Fix aura build for android." > 5490bafef2f11416bed41ad8017a6db500c67345: "Split vector icon commands into separate files aggregated at build time." > 33b823af3e63287dbe850c253ae97593411d4f43: "Introduce some util code for drawing vector assets." > > Reason for revert is 33b823af3e63287dbe850c253ae97593411d4f43, which > is one of the suspects for having broken browser_tests on Mac builders: > > http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/8232 > http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/4313 > > Log output: > > NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 (run #1): > [ RUN ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 > [7393:1287:0708/150523:WARNING:vt_video_decode_accelerator.cc(206)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled. > [7390:45827:0708/150524:WARNING:data_reduction_proxy_config.cc(630)] SPDY proxy OFF at startup > ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:645: Failure > Value of: [color redComponent] > Actual: 0.952941 > Expected: 0 > ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:646: Failure > Value of: [color greenComponent] > Actual: 0.952941 > Expected: 0 > ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:647: Failure > Value of: [color blueComponent] > Actual: 0.952941 > Expected: 1 > ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:654: Failure > Value of: [color redComponent] > Actual: 0.952941 > Expected: 1 > ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:655: Failure > Value of: [color greenComponent] > Actual: 0.952941 > Expected: 0 > ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:656: Failure > Value of: [color blueComponent] > Actual: 0.952941 > Expected: 0 > [ FAILED ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0, where GetParam() = false (1817 ms) > > BUG=508389 > TBR=estade@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/17399fb2b0a5fcba7c2dcb76ab2c597e6cf7c0db TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508389 Committed: https://chromium.googlesource.com/chromium/src/+/b1fdeb5ac2b5ca9392e1e35aafe9a1230bc8a5b5

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -41 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 1 chunk +3 lines, -1 line 0 comments Download
A chrome/browser/resources/help/check_circle.svg View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/help/help_content.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 3 chunks +33 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 chunks +37 lines, -1 line 0 comments Download
A ui/gfx/paint_vector_icon.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A ui/gfx/paint_vector_icon.cc View 1 1 chunk +121 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/aggregate_vector_icons.py View 1 1 chunk +75 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/check_circle.icon View 1 1 chunk +9 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/photo_camera.icon View 1 1 chunk +17 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/vector_icons.cc.template View 1 1 chunk +34 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/vector_icons_public.h.template View 1 1 chunk +20 lines, -0 lines 0 comments Download
D ui/resources/default_100_percent/common/checkmark.png View 1 Binary file 0 comments Download
D ui/resources/default_200_percent/common/checkmark.png View 1 Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/image_view.h View 1 4 chunks +18 lines, -5 lines 0 comments Download
M ui/views/controls/image_view.cc View 1 6 chunks +22 lines, -9 lines 0 comments Download
M ui/views/controls/throbber.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M ui/views/controls/throbber.cc View 1 3 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mattias Nissler (ping if slow)
Created Revert of Revert vector icon CLs.
5 years, 5 months ago (2015-07-09 11:32:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231843002/1
5 years, 5 months ago (2015-07-09 11:32:27 UTC) #2
commit-bot: I haz the power
Failed to apply patch for ui/resources/ui_resources.grd: While running git apply --index -3 -p1; error: patch ...
5 years, 5 months ago (2015-07-09 11:33:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231843002/290001
5 years, 5 months ago (2015-07-09 12:03:46 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
5 years, 5 months ago (2015-07-09 12:04:10 UTC) #8
Mattias Nissler (ping if slow)
5 years, 5 months ago (2015-07-09 12:12:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:290001) manually as
b1fdeb5ac2b5ca9392e1e35aafe9a1230bc8a5b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698