Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 12317072: Merge 143386 (Closed)

Created:
7 years, 10 months ago by adamk
Modified:
7 years, 10 months ago
Reviewers:
esprehn
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 143386 > Support both MutationObserver and WebKitMutationObserver > https://bugs.webkit.org/show_bug.cgi?id=109776 > > Reviewed by Ojan Vafai. > > Source/WebCore: > > We should allow new MutationObserver now that we support parser generated > mutations. This leaves the old prefixed constructor in until we decide > people don't depend on it. > > Test: fast/dom/MutationObserver/mutation-observer-prefix.html > > * page/DOMWindow.idl: > > LayoutTests: > > * fast/dom/MutationObserver/added-out-of-order.html: > * fast/dom/MutationObserver/callback-arguments.html: > * fast/dom/MutationObserver/clear-transient-without-delivery.html: > * fast/dom/MutationObserver/create-during-delivery.html: > * fast/dom/MutationObserver/cross-document.html: > * fast/dom/MutationObserver/database-callback-delivery.html: > * fast/dom/MutationObserver/delivery-order.html: > * fast/dom/MutationObserver/disconnect-cancel-pending.html: > * fast/dom/MutationObserver/document-fragment-insertion.html: > * fast/dom/MutationObserver/end-of-task-delivery.html: > * fast/dom/MutationObserver/filesystem-callback-delivery.html: > * fast/dom/MutationObserver/inline-event-listener.html: > * fast/dom/MutationObserver/mutate-during-delivery.html: > * fast/dom/MutationObserver/mutation-callback-non-element-crash.html: > * fast/dom/MutationObserver/mutation-observer-constructor.html: > * fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added. > * fast/dom/MutationObserver/mutation-observer-prefix.html: Added. > * fast/dom/MutationObserver/mutation-record-nullity.html: > * fast/dom/MutationObserver/observe-attributes.html: > * fast/dom/MutationObserver/observe-characterdata.html: > * fast/dom/MutationObserver/observe-childList.html: > * fast/dom/MutationObserver/observe-exceptions.html: > * fast/dom/MutationObserver/observe-subtree.html: > * fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html: > * fast/dom/MutationObserver/observer-wrapper-dropoff.html: > * fast/dom/MutationObserver/parser-mutations.html: > * fast/dom/MutationObserver/removed-out-of-order.html: > * fast/dom/MutationObserver/shadow-dom.html: > * fast/dom/MutationObserver/takeRecords.html: > * fast/dom/MutationObserver/transient-gc-crash.html: > TBR=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -78 lines) Patch
M LayoutTests/fast/dom/MutationObserver/added-out-of-order.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/callback-arguments.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/clear-transient-without-delivery.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/create-during-delivery.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/cross-document.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/database-callback-delivery.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/delivery-order.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/disconnect-cancel-pending.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/document-fragment-insertion.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/end-of-task-delivery.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/filesystem-callback-delivery.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/inline-event-listener.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/mutate-during-delivery.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/mutation-callback-non-element-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/mutation-observer-constructor.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/MutationObserver/mutation-observer-prefix.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/MutationObserver/mutation-observer-prefix-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/mutation-record-nullity.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-attributes.html View 23 chunks +25 lines, -25 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-characterdata.html View 7 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-childList.html View 9 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-exceptions.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observe-subtree.html View 5 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observer-wrapper-dropoff.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/parser-mutations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/removed-out-of-order.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/shadow-dom.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/takeRecords.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/MutationObserver/transient-gc-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
adamk
7 years, 10 months ago (2013-02-22 18:58:20 UTC) #1
adamk
7 years, 10 months ago (2013-02-22 18:59:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143756.

Powered by Google App Engine
This is Rietveld 408576698