Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Issue 12317063: Revert 183957 (Closed)

Created:
7 years, 10 months ago by calvinlo
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 183957 > pkg-config-wrapper shouldn't clobber PKG_CONFIG_PATH if it is already set > > This allows cross-compilation using sysroots with pkgconfig directories in > non-standard locations. > > Add Opera Software to the AUTHORS file > > > BUG= > > > Review URL: https://chromiumcodereview.appspot.com/12320047 TBR=mostynb@opera.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M build/linux/pkg-config-wrapper View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
calvinlo
7 years, 10 months ago (2013-02-22 03:57:34 UTC) #1
calvinlo
Committed patchset #1 manually as r184008.
7 years, 10 months ago (2013-02-22 03:57:48 UTC) #2
calvinlo
On 2013/02/22 03:57:48, calvinlo wrote: > Committed patchset #1 manually as r184008. I think this ...
7 years, 10 months ago (2013-02-22 04:04:27 UTC) #3
Mostyn Bramley-Moore
Does the build environment have PKG_CONFIG_PATH set? If so, what is it set to? Should ...
7 years, 10 months ago (2013-02-22 07:11:53 UTC) #4
calvinlo
7 years, 10 months ago (2013-02-22 07:14:13 UTC) #5
Message was sent while issue was closed.
I'm honestly not sure, I'm just sheriffing to keep the tree green. Please try
asking in IRC channel or one of the existing authors.

Powered by Google App Engine
This is Rietveld 408576698