Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: sandbox/win/src/sharedmem_ipc_server.h

Issue 1231673002: Sandbox: remove raw handles from SharedMemIPCServer::ServerControl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/win/src/sharedmem_ipc_server.h
diff --git a/sandbox/win/src/sharedmem_ipc_server.h b/sandbox/win/src/sharedmem_ipc_server.h
index 94d6959b81259fbb768e23df7d715348dfb79bdf..8d776d506194ba9bf07e804442ee5c138903fccf 100644
--- a/sandbox/win/src/sharedmem_ipc_server.h
+++ b/sandbox/win/src/sharedmem_ipc_server.h
@@ -9,6 +9,7 @@
#include "base/basictypes.h"
#include "base/gtest_prod_util.h"
+#include "base/win/scoped_handle.h"
#include "sandbox/win/src/crosscall_params.h"
#include "sandbox/win/src/crosscall_server.h"
#include "sandbox/win/src/sharedmem_ipc_client.h"
@@ -63,7 +64,8 @@ class SharedMemIPCServer {
// Makes the client and server events. This function is called once
// per channel.
- bool MakeEvents(HANDLE* server_ping, HANDLE* server_pong,
+ bool MakeEvents(base::win::ScopedHandle* server_ping,
+ base::win::ScopedHandle* server_pong,
HANDLE* client_ping, HANDLE* client_pong);
// A copy this structure is maintained per channel.
@@ -73,9 +75,9 @@ class SharedMemIPCServer {
// call or about threading issues.
struct ServerControl {
// This channel server ping event.
- HANDLE ping_event;
+ base::win::ScopedHandle ping_event;
// This channel server pong event.
- HANDLE pong_event;
+ base::win::ScopedHandle pong_event;
// The size of this channel.
uint32 channel_size;
// The pointer to the actual channel data.

Powered by Google App Engine
This is Rietveld 408576698