Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1231663007: Takes the script offset into account when obtaining the column of the message. (Closed)

Created:
5 years, 5 months ago by epertoso
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Takes the script offset into account when obtaining the column of the message. R=jochen@chromium.org,yangguo@chromium.org Committed: https://crrev.com/6a5285108b479567294064700453c4809c0d215c Cr-Commit-Position: refs/heads/master@{#29761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231663007/1
5 years, 5 months ago (2015-07-16 12:16:21 UTC) #2
epertoso
5 years, 5 months ago (2015-07-16 12:30:37 UTC) #3
Yang
lgtm
5 years, 5 months ago (2015-07-16 12:33:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-16 12:47:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231663007/1
5 years, 5 months ago (2015-07-20 15:22:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 15:56:16 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 15:56:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a5285108b479567294064700453c4809c0d215c
Cr-Commit-Position: refs/heads/master@{#29761}

Powered by Google App Engine
This is Rietveld 408576698