Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: src/messages.js

Issue 1231663007: Takes the script offset into account when obtaining the column of the message. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index cd4664ee2639ba5e4e4cf2ea9ddd7fe74af796e7..63cefc877d695ef2d33a98621efd3c5fc6c92506 100644
--- a/src/messages.js
+++ b/src/messages.js
@@ -542,7 +542,7 @@ utils.SetUpLockedPrototype(SourceSlice,
function GetPositionInLine(message) {
var script = %MessageGetScript(message);
var start_position = %MessageGetStartPosition(message);
- var location = script.locationFromPosition(start_position, false);
+ var location = script.locationFromPosition(start_position, true);
if (location == null) return -1;
return location.column;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698