media: Support CdmFactory in MojoMediaClient.

media/mojo/services/mojo_cdm_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/mojo/services/mojo_cdm_service.h"
 
 #include "base/bind.h"
+#include "media/base/cdm_config.h"
+#include "media/base/cdm_factory.h"
 #include "media/base/cdm_key_information.h"
 #include "media/base/key_systems.h"
-#include "media/cdm/aes_decryptor.h"
 #include "media/mojo/services/media_type_converters.h"
-#include "media/mojo/services/mojo_cdm_promise.h"
 #include "media/mojo/services/mojo_cdm_service_context.h"
 #include "mojo/common/common_type_converters.h"
 #include "mojo/common/url_type_converters.h"
 #include "url/gurl.h"
 
 namespace media {
 
-typedef MojoCdmPromise<> SimpleMojoCdmPromise;
-typedef MojoCdmPromise<std::string> NewSessionMojoCdmPromise;
+using NewSessionMojoCdmPromise = MojoCdmPromise<std::string>;
+using SimpleMojoCdmPromise = MojoCdmPromise<>;
 
 MojoCdmService::MojoCdmService(
     MojoCdmServiceContext* context,
+    CdmFactory* cdm_factory,
     mojo::InterfaceRequest<mojo::ContentDecryptionModule> request)
     : binding_(this, request.Pass()),
       context_(context),
+      cdm_factory_(cdm_factory),
       cdm_id_(CdmContext::kInvalidCdmId),
       weak_factory_(this) {
+  DCHECK(context_);
+  DCHECK(cdm_factory_);
 }
 
 MojoCdmService::~MojoCdmService() {
   if (cdm_id_ != CdmContext::kInvalidCdmId)
     context_->UnregisterCdm(cdm_id_);
 }
 
 void MojoCdmService::SetClient(mojo::ContentDecryptionModuleClientPtr client) {
   client_ = client.Pass();
 }
 
 void MojoCdmService::Initialize(
     const mojo::String& key_system,
     const mojo::String& security_origin,
     int32_t cdm_id,
     const mojo::Callback<void(mojo::CdmPromiseResultPtr)>& callback) {
   DVLOG(1) << __FUNCTION__ << ": " << key_system;
   DCHECK(!cdm_);
   DCHECK_NE(CdmContext::kInvalidCdmId, cdm_id);
 
-  SimpleMojoCdmPromise promise(callback);
-
-  // Only AesDecryptor is supported.
-  // TODO(xhwang): Use a CdmFactory to create the CDM here. See
-  // http://crbug.com/495273
-  if (CanUseAesDecryptor(key_system)) {
-    base::WeakPtr<MojoCdmService> weak_this = weak_factory_.GetWeakPtr();
-    cdm_.reset(new AesDecryptor(
-        GURL::EmptyGURL(),
-        base::Bind(&MojoCdmService::OnSessionMessage, weak_this),
-        base::Bind(&MojoCdmService::OnSessionClosed, weak_this),
-        base::Bind(&MojoCdmService::OnSessionKeysChange, weak_this)));
-    cdm_id_ = cdm_id;
-    context_->RegisterCdm(cdm_id_, this);
-    promise.resolve();
-  } else {
-    // TODO(xhwang): This should not happen when KeySystemInfo is properly
-    // populated. See http://crbug.com/469366
-    promise.reject(MediaKeys::NOT_SUPPORTED_ERROR, 0, "Not supported.");
-  }
+  base::WeakPtr<MojoCdmService> weak_this = weak_factory_.GetWeakPtr();

[ddorwin, 2015/07/09 18:13:03]

Totally optional, but I wonder if "auto" makes sense for weak pointers.
You already have the code, so this is fine. Something to consider in new code.

[xhwang, 2015/07/09 21:16:31]

Done.

+  cdm_factory_->Create(
+      key_system, GURL(security_origin), CdmConfig(),

[ddorwin, 2015/07/09 18:13:03]

TODO: Something about the config?

[xhwang, 2015/07/09 21:16:31]

This will be fixed this week: https://codereview.chromium.org/1227883002/

So I feel a TODO isn't necessary.

+      base::Bind(&MojoCdmService::OnSessionMessage, weak_this),
+      base::Bind(&MojoCdmService::OnSessionClosed, weak_this),
+      base::Bind(&MojoCdmService::OnLegacySessionError, weak_this),
+      base::Bind(&MojoCdmService::OnSessionKeysChange, weak_this),
+      base::Bind(&MojoCdmService::OnSessionExpirationUpdate, weak_this),
+      base::Bind(
+          &MojoCdmService::OnCdmCreated, weak_this, cdm_id,
+          base::Passed(make_scoped_ptr(new SimpleMojoCdmPromise(callback)))));
 }
 
 // mojo::MediaRenderer implementation.
 void MojoCdmService::SetServerCertificate(
     mojo::Array<uint8_t> certificate_data,
     const mojo::Callback<void(mojo::CdmPromiseResultPtr)>& callback) {
   DVLOG(2) << __FUNCTION__;
   cdm_->SetServerCertificate(
       certificate_data.storage(),
       make_scoped_ptr(new SimpleMojoCdmPromise(callback)));
@@ skipping 51 matching lines @@
 
 void MojoCdmService::GetDecryptor(
     mojo::InterfaceRequest<mojo::Decryptor> decryptor) {
   NOTIMPLEMENTED();
 }
 
 CdmContext* MojoCdmService::GetCdmContext() {
   return cdm_->GetCdmContext();
 }
 
+void MojoCdmService::OnCdmCreated(int cdm_id,
+                                  scoped_ptr<SimpleMojoCdmPromise> promise,
+                                  scoped_ptr<MediaKeys> cdm,
+                                  const std::string& error_message) {
+  // TODO(xhwang): This should not happen when KeySystemInfo is properly
+  // populated. See http://crbug.com/469366
+  if (!cdm) {
+    promise->reject(MediaKeys::NOT_SUPPORTED_ERROR, 0, error_message);
+    return;
+  }
+
+  cdm_ = cdm.Pass();
+  cdm_id_ = cdm_id;
+  context_->RegisterCdm(cdm_id_, this);
+  promise->resolve();
+}
+
 void MojoCdmService::OnSessionMessage(const std::string& session_id,
                                       MediaKeys::MessageType message_type,
                                       const std::vector<uint8_t>& message,
                                       const GURL& legacy_destination_url) {
   DVLOG(2) << __FUNCTION__;
   client_->OnSessionMessage(session_id,
                             static_cast<mojo::CdmMessageType>(message_type),
                             mojo::Array<uint8_t>::From(message),
                             mojo::String::From(legacy_destination_url));
 }
@@ skipping 26 matching lines @@
                                           MediaKeys::Exception exception,
                                           uint32_t system_code,
                                           const std::string& error_message) {
   DVLOG(2) << __FUNCTION__;
   client_->OnLegacySessionError(session_id,
                                 static_cast<mojo::CdmException>(exception),
                                 system_code, error_message);
 }
 
 }  // namespace media