Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227883002: media: Pass CdmConfig in mojo CDM interface. (Closed)

Created:
5 years, 5 months ago by xhwang
Modified:
5 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Pass CdmConfig in mojo CDM interface. BUG=432998 Committed: https://crrev.com/d45a72728482ffbdad2aa236935fa433edff4843 Cr-Commit-Position: refs/heads/master@{#338177}

Patch Set 1 #

Patch Set 2 : rebase-only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -15 lines) Patch
M media/mojo/interfaces/content_decryption_module.mojom View 2 chunks +11 lines, -4 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/mojo/services/media_type_converters.h View 2 chunks +12 lines, -2 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 3 chunks +22 lines, -1 line 0 comments Download
M media/mojo/services/media_type_converters_unittest.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_cdm.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
xhwang
PTAL
5 years, 5 months ago (2015-07-08 23:44:59 UTC) #3
sandersd (OOO until July 31)
lgtm.
5 years, 5 months ago (2015-07-09 00:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227883002/20001
5 years, 5 months ago (2015-07-09 22:32:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 22:59:10 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 22:59:57 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d45a72728482ffbdad2aa236935fa433edff4843
Cr-Commit-Position: refs/heads/master@{#338177}

Powered by Google App Engine
This is Rietveld 408576698