Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Unified Diff: pkg/unittest/lib/compact_vm_config.dart

Issue 12316072: Some fixes in unittest after io v2 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: also include htmlconfig Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/unittest/lib/html_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/compact_vm_config.dart
diff --git a/pkg/unittest/lib/compact_vm_config.dart b/pkg/unittest/lib/compact_vm_config.dart
index 6b46a656692fa6b755461cf08620b64748bc01ad..ede701025cf8f8bff110684ce84a0610d211f9ed 100644
--- a/pkg/unittest/lib/compact_vm_config.dart
+++ b/pkg/unittest/lib/compact_vm_config.dart
@@ -89,24 +89,24 @@ class CompactVMConfiguration extends VMConfiguration {
var duration = (new DateTime.now()).difference(startTime);
var buffer = new StringBuffer();
// \r moves back to the beginnig of the current line.
- buffer.add('\r${_timeString(duration)} ');
- buffer.add(_GREEN);
- buffer.add('+');
- buffer.add(passed);
- buffer.add(_NONE);
- if (failed != 0) buffer.add(_RED);
- buffer.add(' -');
- buffer.add(failed);
- if (failed != 0) buffer.add(_NONE);
- buffer.add(': ');
- buffer.add(color);
+ buffer.write('\r${_timeString(duration)} ');
+ buffer.write(_GREEN);
+ buffer.write('+');
+ buffer.write(passed);
+ buffer.write(_NONE);
+ if (failed != 0) buffer.write(_RED);
+ buffer.write(' -');
+ buffer.write(failed);
+ if (failed != 0) buffer.write(_NONE);
+ buffer.write(': ');
+ buffer.write(color);
int nonVisible = _nonVisiblePrefix + color.length +
gram 2013/02/22 17:36:11 Can you add a comment to this block of code please
Siggi Cherem (dart-lang) 2013/02/22 17:39:00 already submitted this one, but will do in a separ
(failed != 0 ? (_RED.length + _NONE.length) : 0);
int len = buffer.length - nonVisible;
var mx = MAX_LINE - len;
- buffer.add(_snippet(message, MAX_LINE - len));
- buffer.add(_NONE);
+ buffer.write(_snippet(message, MAX_LINE - len));
+ buffer.write(_NONE);
// Pad the rest of the line so that it looks erased.
len = buffer.length - nonVisible - _NONE.length;
@@ -114,11 +114,11 @@ class CompactVMConfiguration extends VMConfiguration {
_lastLength = len;
} else {
while (len < _lastLength) {
- buffer.add(' ');
+ buffer.write(' ');
_lastLength--;
}
}
- stdout.writeString(buffer.toString());
+ stdout.addString(buffer.toString());
}
String _padTime(int time) =>
@@ -146,11 +146,11 @@ class CompactVMConfiguration extends VMConfiguration {
if (i < words.length - 4) {
// Require at least 3 words at the end.
var buffer = new StringBuffer();
- buffer.add(words.first);
- buffer.add(' ...');
+ buffer.write(words.first);
+ buffer.write(' ...');
for (; i < words.length; i++) {
- buffer.add(' ');
- buffer.add(words[i]);
+ buffer.write(' ');
+ buffer.write(words[i]);
}
return buffer.toString();
}
« no previous file with comments | « no previous file | pkg/unittest/lib/html_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698