Some fixes in unittest after io v2

pkg/unittest/lib/compact_vm_config.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A test configuration that generates a compact 1-line progress bar. The bar is
  * updated in-place before and after each test is executed. If all test pass,
  * you should only see a couple lines in the terminal. If a test fails, the
  * failure is shown and the progress bar continues to be updated below it.
  */
@@ skipping 71 matching lines @@
 
   int _lastLength = 0;
 
   final int _nonVisiblePrefix = 1 + _GREEN.length + _NONE.length;
 
   void _progressLine(DateTime startTime, int passed, int failed, String message,
       [String color = _NONE]) {
     var duration = (new DateTime.now()).difference(startTime);
     var buffer = new StringBuffer();
     // \r moves back to the beginnig of the current line.
-    buffer.add('\r${_timeString(duration)} ');
-    buffer.add(_GREEN);
-    buffer.add('+');
-    buffer.add(passed);
-    buffer.add(_NONE);
-    if (failed != 0) buffer.add(_RED);
-    buffer.add(' -');
-    buffer.add(failed);
-    if (failed != 0) buffer.add(_NONE);
-    buffer.add(': ');
-    buffer.add(color);
+    buffer.write('\r${_timeString(duration)} ');
+    buffer.write(_GREEN);
+    buffer.write('+');
+    buffer.write(passed);
+    buffer.write(_NONE);
+    if (failed != 0) buffer.write(_RED);
+    buffer.write(' -');
+    buffer.write(failed);
+    if (failed != 0) buffer.write(_NONE);
+    buffer.write(': ');
+    buffer.write(color);
 
     int nonVisible = _nonVisiblePrefix + color.length  +

[gram, 2013/02/22 17:36:11]

Can you add a comment to this block of code please? It is not obvious what it is
doing.

[Siggi Cherem (dart-lang), 2013/02/22 17:39:00]

already submitted this one, but will do in a separate CL.

         (failed != 0 ? (_RED.length + _NONE.length) : 0);
     int len = buffer.length - nonVisible;
     var mx = MAX_LINE - len;
-    buffer.add(_snippet(message, MAX_LINE - len));
-    buffer.add(_NONE);
+    buffer.write(_snippet(message, MAX_LINE - len));
+    buffer.write(_NONE);
 
     // Pad the rest of the line so that it looks erased.
     len = buffer.length - nonVisible - _NONE.length;
     if (len > _lastLength) {
       _lastLength = len;
     } else {
       while (len < _lastLength) {
-        buffer.add(' ');
+        buffer.write(' ');
         _lastLength--;
       }
     }
-    stdout.writeString(buffer.toString());
+    stdout.addString(buffer.toString());
   }
 
   String _padTime(int time) =>
     (time == 0) ? '00' : ((time < 10) ? '0$time' : '$time');
 
   String _timeString(Duration duration) {
     var min = duration.inMinutes;
     var sec = duration.inSeconds % 60;
     return '${_padTime(min)}:${_padTime(sec)}';
   }
 
   String _snippet(String text, int maxLength) {
     // Return the full message if it fits
     if (text.length <= maxLength) return text;
 
     // If we can fit the first and last three words, do so.
     var words = text.split(' ');
     if (words.length > 1) {
       int i = words.length;
       var len = words.first.length + 4;
       do {
         len += 1 + words[--i].length;
       } while (len <= maxLength && i > 0);
       if (len > maxLength || i == 0) i++;
       if (i < words.length - 4) {
         // Require at least 3 words at the end.
         var buffer = new StringBuffer();
-        buffer.add(words.first);
-        buffer.add(' ...');
+        buffer.write(words.first);
+        buffer.write(' ...');
         for (; i < words.length; i++) {
-          buffer.add(' ');
-          buffer.add(words[i]);
+          buffer.write(' ');
+          buffer.write(words[i]);
         }
         return buffer.toString();
       }
     }
 
     // Otherwise truncate to return the trailing text, but attempt to start at
     // the beginning of a word.
     var res = text.substring(text.length - maxLength + 4);
     var firstSpace = res.indexOf(' ');
     if (firstSpace > 0) {
       res = res.substring(firstSpace);
     }
     return '...$res';
   }
 }
 
 void useCompactVMConfiguration() {
   if (config != null) return;
   configure(new CompactVMConfiguration());
 }