runtime/vm/flow_graph_builder.cc - Issue 12316065: Set instruction/use_index when adding an input to an IL instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 12316065: Set instruction/use_index when adding an input to an IL instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Incorporated review comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index 8bcba377b00fe35d4d191fabf54db985e9c789b1..33fad69afca7109c49c68967186f8a48629d4fd8 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -205,10 +205,7 @@ void ValueInliningContext::ReplaceCall(FlowGraph* caller_graph,

phi->set_ssa_temp_index(caller_graph->alloc_ssa_temp_index());

phi->mark_alive();

for (intptr_t i = 0; i < num_exits; ++i) {

- Value* value = ValueAt(i);

- phi->SetInputAt(i, value);

- value->set_instruction(phi);

- value->set_use_index(i);

+ phi->SetInputAt(i, ValueAt(i));

}

// Replace uses of the call with the phi.

call->ReplaceUsesWith(phi);

« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »