Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: runtime/vm/flow_graph.cc

Issue 12316065: Set instruction/use_index when adding an input to an IL instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporated review comments. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph.cc
diff --git a/runtime/vm/flow_graph.cc b/runtime/vm/flow_graph.cc
index e7598ac0e07aabda2dc6ecec5435d37cd7eff979..2c988871a5261f7b710465156796c887138bb0d5 100644
--- a/runtime/vm/flow_graph.cc
+++ b/runtime/vm/flow_graph.cc
@@ -75,8 +75,6 @@ void FlowGraph::InsertAfter(Instruction* prev,
for (intptr_t i = instr->InputCount() - 1; i >= 0; --i) {
Value* input = instr->InputAt(i);
input->definition()->AddInputUse(input);
- input->set_instruction(instr);
- input->set_use_index(i);
}
ASSERT(instr->env() == NULL);
if (env != NULL) env->DeepCopyTo(instr);
@@ -508,8 +506,6 @@ void FlowGraph::RenameRecursive(BlockEntryInstr* block_entry,
v->set_definition(reaching_defn);
input_defn = reaching_defn;
}
- v->set_instruction(current);
- v->set_use_index(i);
input_defn->AddInputUse(v);
}
@@ -591,8 +587,6 @@ void FlowGraph::RenameRecursive(BlockEntryInstr* block_entry,
// Rename input operand.
Value* use = new Value((*env)[i]);
phi->SetInputAt(pred_index, use);
- use->set_instruction(phi);
- use->set_use_index(pred_index);
use->definition()->AddInputUse(use);
}
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698