Issue 12316032: Added more Chrome.* libraries to dart:chrome

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7007 lines, -323 lines)			Patch
M	sdk/lib/chrome/dart2js/chrome_dart2js.dart	View		10 chunks	+3483 lines, -161 lines	0 comments	Download
M	tools/dom/scripts/chromegenerator.py	View	1 2	2 chunks	+16 lines, -2 lines	0 comments	Download
A	tools/dom/src/chrome/alarms.dart	View		1 chunk	+212 lines, -0 lines	0 comments	Download
M	tools/dom/src/chrome/app_runtime.dart	View		5 chunks	+2 lines, -106 lines	0 comments	Download
M	tools/dom/src/chrome/app_window.dart	View	1 2	3 chunks	+51 lines, -51 lines	0 comments	Download
A	tools/dom/src/chrome/bluetooth.dart	View		1 chunk	+618 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/context_menus.dart	View		1 chunk	+208 lines, -0 lines	0 comments	Download
A +	tools/dom/src/chrome/custom_dart/app_window.isMaximised.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
A	tools/dom/src/chrome/file_system.dart	View		1 chunk	+181 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/media_galleries.dart	View		1 chunk	+135 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/media_galleries_private.dart	View		1 chunk	+273 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/push_messaging.dart	View		1 chunk	+145 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/serial.dart	View		1 chunk	+256 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/socket.dart	View		1 chunk	+447 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/sync_file_system.dart	View		1 chunk	+256 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/system_indicator.dart	View		1 chunk	+94 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/system_info_display.dart	View		1 chunk	+214 lines, -0 lines	0 comments	Download
A	tools/dom/src/chrome/usb.dart	View		1 chunk	+401 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate	View		2 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sashab

So I generated the latest Chrome IDLs with JSON Schema Compiler, and have uploaded them ...

7 years, 10 months ago (2013-02-21 03:22:18 UTC) #1

benwells

On 2013/02/21 03:22:18, sasha_b wrote: > So I generated the latest Chrome IDLs with JSON ...

7 years, 10 months ago (2013-02-25 04:36:43 UTC) #2

blois

7 years, 10 months ago (2013-02-25 21:44:41 UTC) #3

On 2013/02/25 04:36:43, benwells wrote:
> On 2013/02/21 03:22:18, sasha_b wrote:
> > So I generated the latest Chrome IDLs with JSON Schema Compiler, and have
> > uploaded them here. I'm not sure if they're ready to commit yet - there are
a
> > few strange errors in places - but if you could have a skim over them,
noting
> > anything strange you spot, that would be great :)
> > 
> >
>
https://codereview.chromium.org/12316032/diff/1001/tools/dom/src/chrome/app_w...
> > File tools/dom/src/chrome/app_window.dart (right):
> > 
> >
>
https://codereview.chromium.org/12316032/diff/1001/tools/dom/src/chrome/app_w...
> > tools/dom/src/chrome/app_window.dart:300: bool isMaximized() => new
> > bool._proxy(JS('', '#.isMaximized()', this._jsObject));
> > So, this is an interesting case. Apparently "bool" is interpreted as an
object
> > reference, but "boolean" is the type. This seems to be a problem in the IDL
> file
> > itself.
> 
> blois: fyi, am going to fix some problems with the generator before revisiting
> this, since Sasha's internship has finished.
> 
> Let me know if you have any opinions on how to bring in the rest of the APIs.

These changes look straightforward- what APIs are remaining?

Expand Messages | Collapse Messages