Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 1231533002: Deprecate Element.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/dom/Element.idl ('K') | « Source/core/dom/Element.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/UseCounter.cpp
diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp
index 1e6ff3220c3f97fcefae56edb2f6f0cc9c1b0f52..7cde5edacec465c2d558fcb0d6e552c9ed9efa6c 100644
--- a/Source/core/frame/UseCounter.cpp
+++ b/Source/core/frame/UseCounter.cpp
@@ -947,6 +947,21 @@ String UseCounter::deprecationMessage(Feature feature)
case PermissionStatusStatus:
return "PermissionStatus.status is deprecated and will be removed in M47, around November 2015. Please use PermissionStatus.state instead.";
+ case ElementOffsetParent:
+ return "'Element.offsetParent' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely supported for HTML elements";
philipj_slow 2015/07/08 12:16:20 There should be a period at the end of this messag
tanay.c 2015/07/10 09:07:20 Done.
+
+ case ElementOffsetTop:
+ return "'Element.offsetTop' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely supported for HTML elements";
+
+ case ElementOffsetLeft:
+ return "'Element.offsetLeft' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely supported for HTML elements";
+
+ case ElementOffsetWidth:
+ return "'Element.offsetWidth' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely supported for HTML elements";
+
+ case ElementOffsetHeight:
+ return "'Element.offsetHeight' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely supported for HTML elements";
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« Source/core/dom/Element.idl ('K') | « Source/core/dom/Element.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698