Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1231533002: Deprecate Element.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« Source/core/dom/Element.idl ('K') | « Source/core/dom/Element.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 929 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 940
941 case MediaStreamStop: 941 case MediaStreamStop:
942 return "'MediaStream.stop()' is deprecated and will be removed in M47, a round November 2015. Please use 'MediaStream.active' instead."; 942 return "'MediaStream.stop()' is deprecated and will be removed in M47, a round November 2015. Please use 'MediaStream.active' instead.";
943 943
944 case MediaStreamEnded: 944 case MediaStreamEnded:
945 return "'MediaStream.ended' is deprecated and will be removed in M47, ar ound November 2015. Please use 'MediaStream.active' instead."; 945 return "'MediaStream.ended' is deprecated and will be removed in M47, ar ound November 2015. Please use 'MediaStream.active' instead.";
946 946
947 case PermissionStatusStatus: 947 case PermissionStatusStatus:
948 return "PermissionStatus.status is deprecated and will be removed in M47 , around November 2015. Please use PermissionStatus.state instead."; 948 return "PermissionStatus.status is deprecated and will be removed in M47 , around November 2015. Please use PermissionStatus.state instead.";
949 949
950 case ElementOffsetParent:
951 return "'Element.offsetParent' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely s upported for HTML elements";
philipj_slow 2015/07/08 12:16:20 There should be a period at the end of this messag
tanay.c 2015/07/10 09:07:20 Done.
952
953 case ElementOffsetTop:
954 return "'Element.offsetTop' is deprecated and will be removed in M47, ar ound Novemver 2015. The offset* attributes are only standardized and widely supp orted for HTML elements";
955
956 case ElementOffsetLeft:
957 return "'Element.offsetLeft' is deprecated and will be removed in M47, a round Novemver 2015. The offset* attributes are only standardized and widely sup ported for HTML elements";
958
959 case ElementOffsetWidth:
960 return "'Element.offsetWidth' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely su pported for HTML elements";
961
962 case ElementOffsetHeight:
963 return "'Element.offsetHeight' is deprecated and will be removed in M47, around Novemver 2015. The offset* attributes are only standardized and widely s upported for HTML elements";
964
950 // Features that aren't deprecated don't have a deprecation message. 965 // Features that aren't deprecated don't have a deprecation message.
951 default: 966 default:
952 return String(); 967 return String();
953 } 968 }
954 } 969 }
955 970
956 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 971 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
957 { 972 {
958 ASSERT(feature >= firstCSSProperty); 973 ASSERT(feature >= firstCSSProperty);
959 ASSERT(feature <= lastUnresolvedCSSProperty); 974 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
987 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 1002 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
988 { 1003 {
989 // FIXME: We may want to handle stylesheets that have multiple owners 1004 // FIXME: We may want to handle stylesheets that have multiple owners
990 // http://crbug.com/242125 1005 // http://crbug.com/242125
991 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1006 if (sheetContents && sheetContents->hasSingleOwnerNode())
992 return getFrom(sheetContents->singleOwnerDocument()); 1007 return getFrom(sheetContents->singleOwnerDocument());
993 return 0; 1008 return 0;
994 } 1009 }
995 1010
996 } // namespace blink 1011 } // namespace blink
OLDNEW
« Source/core/dom/Element.idl ('K') | « Source/core/dom/Element.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698