Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 12315133: Very simple set of docs for experimental notification API (Closed)

Created:
7 years, 9 months ago by mkearney1
Modified:
7 years, 9 months ago
Reviewers:
miket_OOO, somast1
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Very simple set of docs for experimental notification API These docs will be greatly improved once notification API moves to stable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185994

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -1 line) Patch
M chrome/common/extensions/api/experimental_notification.idl View 1 chunk +1 line, -1 line 2 comments Download
A chrome/common/extensions/docs/templates/intros/experimental_notification.html View 1 2 1 chunk +123 lines, -0 lines 8 comments Download
A chrome/common/extensions/docs/templates/public/apps/experimental_notification.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mkearney1
First go at notification docs still in experimental.
7 years, 9 months ago (2013-03-01 00:13:02 UTC) #1
miket_OOO
lgtm https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/api/experimental_notification.idl File chrome/common/extensions/api/experimental_notification.idl (right): https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/api/experimental_notification.idl#newcode5 chrome/common/extensions/api/experimental_notification.idl:5: namespace experimental.notification { See https://codereview.chromium.org/12313115/. Dropping experimental, changing ...
7 years, 9 months ago (2013-03-04 22:06:56 UTC) #2
mkearney1
Committed patchset #3 manually as r185994 (presubmit successful).
7 years, 9 months ago (2013-03-04 22:19:53 UTC) #3
mkearney1
7 years, 9 months ago (2013-03-06 00:03:40 UTC) #4
Message was sent while issue was closed.
Hey, Mike

I implemented as many of these comments as I could in new cl:
https://codereview.chromium.org/12497004

Sending that to you for review in a sec.

https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/a...
File chrome/common/extensions/api/experimental_notification.idl (right):

https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/a...
chrome/common/extensions/api/experimental_notification.idl:5: namespace
experimental.notification {
Holding off on this until official move out of experimental so I don't break
anything. Filename will need to change as well.

On 2013/03/04 22:06:56, miket wrote:
> See https://codereview.chromium.org/12313115/. Dropping experimental, changing
> to plural "notifications."

https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/d...
File
chrome/common/extensions/docs/templates/intros/experimental_notification.html
(right):

https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/intros/experimental_notification.html:16:
<a href="experimental.html#using">"Experimental Extensions API"</a>.</td>
On 2013/03/04 22:06:56, miket wrote:
> See above. Current dev- canary- trunk only.

Done.

https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/intros/experimental_notification.html:20:
<td><code>"experimental"</code></td>
On 2013/03/04 22:06:56, miket wrote:
> notifications

Done.

https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/intros/experimental_notification.html:32:
however, some information may not be displayed.
Cool. Removed sentence for now and starred the issue to track progress.

On 2013/03/04 22:06:56, miket wrote:
> This might not currently be the case on Linux/Mac, but it's a good idea.
Entered
> as crbug.com/180001.

https://codereview.chromium.org/12315133/diff/6001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/intros/experimental_notification.html:68:
all icon and image URLs in packaged apps should point to a local resource.
I changed the 'all icon and image URLs' to 'all of these URLs' since we discuss
the official names above.

On 2013/03/04 22:06:56, miket wrote:
> ... or use a data URL (see
http://developer.chrome.com/apps/app_external.html).
> 
> Also, does it make sense to say "icons and/or images"? Aren't all icons
images?
> Why not just say images?
> 
> Maybe you mean that this discussion applies to icon fields and image fields in
> this API. That might make sense.

Powered by Google App Engine
This is Rietveld 408576698