Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 12315053: Fix prefs registration in SyncPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment change. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 32eb6b4fdced741d8a786ad9b28b8745a956b03a..adcd491c48aeb3c7e9988e7c924173d97a66ef24 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -256,18 +256,14 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
#endif
}
-void RegisterUserPrefs(PrefService* user_prefs,
- PrefRegistrySyncable* registry) {
- // TODO(joi): Get rid of the need for the PrefService parameter, and
- // do registration prior to PrefService creation.
-
+void RegisterUserPrefs(PrefRegistrySyncable* registry) {
Mattias Nissler (ping if slow) 2013/02/22 15:44:32 w00t!
Jói 2013/02/22 16:08:07 Indeed :)
// User prefs. Please keep this list alphabetized.
AlternateErrorPageTabObserver::RegisterUserPrefs(registry);
AutofillManager::RegisterUserPrefs(registry);
BookmarkPromptPrefs::RegisterUserPrefs(registry);
bookmark_utils::RegisterUserPrefs(registry);
BrowserInstantController::RegisterUserPrefs(registry);
- browser_sync::SyncPrefs::RegisterUserPrefs(user_prefs, registry);
+ browser_sync::SyncPrefs::RegisterUserPrefs(registry);
ChromeContentBrowserClient::RegisterUserPrefs(registry);
ChromeDownloadManagerDelegate::RegisterUserPrefs(registry);
ChromeVersionService::RegisterUserPrefs(registry);

Powered by Google App Engine
This is Rietveld 408576698