Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: chrome/browser/prefs/browser_prefs.cc

Issue 12315053: Fix prefs registration in SyncPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment change. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/browser_prefs.h" 5 #include "chrome/browser/prefs/browser_prefs.h"
6 6
7 #include "apps/prefs.h" 7 #include "apps/prefs.h"
8 #include "base/prefs/pref_registry_simple.h" 8 #include "base/prefs/pref_registry_simple.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "chrome/browser/about_flags.h" 10 #include "chrome/browser/about_flags.h"
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 249
250 #if defined(OS_MACOSX) 250 #if defined(OS_MACOSX)
251 confirm_quit::RegisterLocalState(registry); 251 confirm_quit::RegisterLocalState(registry);
252 #endif 252 #endif
253 253
254 #if defined(ENABLE_SETTINGS_APP) 254 #if defined(ENABLE_SETTINGS_APP)
255 chrome::RegisterAppListPrefs(registry); 255 chrome::RegisterAppListPrefs(registry);
256 #endif 256 #endif
257 } 257 }
258 258
259 void RegisterUserPrefs(PrefService* user_prefs, 259 void RegisterUserPrefs(PrefRegistrySyncable* registry) {
Mattias Nissler (ping if slow) 2013/02/22 15:44:32 w00t!
Jói 2013/02/22 16:08:07 Indeed :)
260 PrefRegistrySyncable* registry) {
261 // TODO(joi): Get rid of the need for the PrefService parameter, and
262 // do registration prior to PrefService creation.
263
264 // User prefs. Please keep this list alphabetized. 260 // User prefs. Please keep this list alphabetized.
265 AlternateErrorPageTabObserver::RegisterUserPrefs(registry); 261 AlternateErrorPageTabObserver::RegisterUserPrefs(registry);
266 AutofillManager::RegisterUserPrefs(registry); 262 AutofillManager::RegisterUserPrefs(registry);
267 BookmarkPromptPrefs::RegisterUserPrefs(registry); 263 BookmarkPromptPrefs::RegisterUserPrefs(registry);
268 bookmark_utils::RegisterUserPrefs(registry); 264 bookmark_utils::RegisterUserPrefs(registry);
269 BrowserInstantController::RegisterUserPrefs(registry); 265 BrowserInstantController::RegisterUserPrefs(registry);
270 browser_sync::SyncPrefs::RegisterUserPrefs(user_prefs, registry); 266 browser_sync::SyncPrefs::RegisterUserPrefs(registry);
271 ChromeContentBrowserClient::RegisterUserPrefs(registry); 267 ChromeContentBrowserClient::RegisterUserPrefs(registry);
272 ChromeDownloadManagerDelegate::RegisterUserPrefs(registry); 268 ChromeDownloadManagerDelegate::RegisterUserPrefs(registry);
273 ChromeVersionService::RegisterUserPrefs(registry); 269 ChromeVersionService::RegisterUserPrefs(registry);
274 chrome_browser_net::HttpServerPropertiesManager::RegisterUserPrefs( 270 chrome_browser_net::HttpServerPropertiesManager::RegisterUserPrefs(
275 registry); 271 registry);
276 chrome_browser_net::Predictor::RegisterUserPrefs(registry); 272 chrome_browser_net::Predictor::RegisterUserPrefs(registry);
277 DownloadPrefs::RegisterUserPrefs(registry); 273 DownloadPrefs::RegisterUserPrefs(registry);
278 extensions::ComponentLoader::RegisterUserPrefs(registry); 274 extensions::ComponentLoader::RegisterUserPrefs(registry);
279 extensions::ExtensionPrefs::RegisterUserPrefs(registry); 275 extensions::ExtensionPrefs::RegisterUserPrefs(registry);
280 ExtensionWebUI::RegisterUserPrefs(registry); 276 ExtensionWebUI::RegisterUserPrefs(registry);
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 } 431 }
436 local_state->ClearPref(prefs::kLastPromptedGoogleURL); 432 local_state->ClearPref(prefs::kLastPromptedGoogleURL);
437 433
438 current_version |= GOOGLE_URL_TRACKER_PREFS; 434 current_version |= GOOGLE_URL_TRACKER_PREFS;
439 local_state->SetInteger(prefs::kMultipleProfilePrefMigration, 435 local_state->SetInteger(prefs::kMultipleProfilePrefMigration,
440 current_version); 436 current_version);
441 } 437 }
442 } 438 }
443 439
444 } // namespace chrome 440 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698