Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1231473002: d8 workers: fix race on quit() with context_mutex_ (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

d8 workers: fix race on quit() with context_mutex_ When quit() is called, d8 shell exits without cleanup. If a worker is running, it might be holding the context_mutex_, which if destroyed will DCHECK. BUG=v8:4279 R=jarin@chromium.org LOG=n Committed: https://crrev.com/d42e81d587c725e38da3a53fc581db0e3476e408 Cr-Commit-Position: refs/heads/master@{#29557}

Patch Set 1 #

Patch Set 2 : add regression test #

Patch Set 3 : fix V8_SHARED and omit_quit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/d8.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-4279.js View 1 2 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
5 years, 5 months ago (2015-07-07 21:48:49 UTC) #1
Jarin
lgtm
5 years, 5 months ago (2015-07-08 06:54:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231473002/40001
5 years, 5 months ago (2015-07-09 18:52:27 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-09 19:30:26 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 19:30:37 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d42e81d587c725e38da3a53fc581db0e3476e408
Cr-Commit-Position: refs/heads/master@{#29557}

Powered by Google App Engine
This is Rietveld 408576698