src/d8.cc - Issue 1231473002: d8 workers: fix race on quit() with context_mutex_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 1231473002: d8 workers: fix race on quit() with context_mutex_ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix V8_SHARED and omit_quit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 7db6f3ed9e442081528e05140bd25b8911e26cb6..854727125fda5e0147e979a863513e7917d20dd7 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -810,6 +810,9 @@ void Shell::WorkerTerminate(const v8::FunctionCallbackInfo<v8::Value>& args) {

void Shell::Quit(const v8::FunctionCallbackInfo<v8::Value>& args) {

int exit_code = args[0]->Int32Value();

+#ifndef V8_SHARED

+ CleanupWorkers();

+#endif // !V8_SHARED

OnExit(args.GetIsolate());

exit(exit_code);

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-4279.js » ('j') | no next file with comments »