Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1231433004: Merge crrev.com/1151663002 into M44. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m44
Target Ref:
refs/heads/chrome/m44
Project:
skia
Visibility:
Public.

Description

Merge crrev.com/1151663002 into M44. Patched nearly cleanly, with some cosmetic conflics in SkPicture.h. Original change: Don't serialize SkPictures in SkPictureShaders when in untrusted mode. This requires we "first" add a has-picture bool to SkPictureShader serialized format. BUG=chromium:486947 , billions and billions of others. Review URL: https://codereview.chromium.org/1151663002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/1dd3830b7254eaea8d710b256f7f040668f02458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M include/core/SkPicture.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkPictureShader.cpp View 3 chunks +35 lines, -2 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231433004/1
5 years, 5 months ago (2015-07-07 15:11:43 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 5 months ago (2015-07-07 15:11:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231433004/1
5 years, 5 months ago (2015-07-07 15:13:05 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 15:13:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1dd3830b7254eaea8d710b256f7f040668f02458

Powered by Google App Engine
This is Rietveld 408576698