Issue 1151663002: Don't serialize SkPictures in SkPictureShaders when in untrusted mode.

Issue 1151663002: Don't serialize SkPictures in SkPictureShaders when in untrusted mode. (Closed)

Created:
5 years, 7 months ago by mtklein_C

Modified:
5 years, 7 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Don't serialize SkPictures in SkPictureShaders when in untrusted mode. This requires we "first" add a has-picture bool to SkPictureShader serialized format. BUG=chromium:486947 , billions and billions of others. Committed: https://skia.googlesource.com/skia/+/76be9c8dc0e5306ef81c2987848088cdec7ccd3f

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -4 lines)			Patch
M	include/core/SkPicture.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/core/SkPictureShader.cpp	View	1	3 chunks	+35 lines, -2 lines	0 comments	Download
M	src/core/SkReadBuffer.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 9 (4 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151663002/20001

5 years, 7 months ago (2015-05-20 18:51:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151663002/20001

5 years, 7 months ago (2015-05-20 18:54:32 UTC) #8

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 19:05:18 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/76be9c8dc0e5306ef81c2987848088cdec7ccd3f