Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html

Issue 12314017: Revert 143493 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html
===================================================================
--- LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html (revision 143493)
+++ LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html (working copy)
@@ -1,47 +0,0 @@
-<!DOCTYPE html>
-
-<style>
- /* Must be positioned absolute or static, must have margins to push it out view. */
- .positioned {
- position: absolute;
- margin-top: 100%;
- }
-
- /* Any kind of quote will do, can be either :before or :after */
- .positioned:before,
- .focusable:before {
- content: open-quote;
- }
-</style>
-
-<p>Bug 109616 - ASSERT(!renderer()->needsLayout()) when calling Element::focus() with generated content</p>
-
-<!--
- This is testing a case where RenderQuote::updateDepth will mark the RenderQuote
- and its ancestors as needing layout in the middle of a layout of its ancestor.
- When its ancestor finishes the layout it will mark itself and the ancestors
- farther up as no longer needing layout. The end result is some subtree
- needing layout, but the RenderView and possibly other ancestors of the subtree
- not needing layout.
-
- ex.
-
- RenderView <- !needsLayout
- \
- RenderBlock (.focusable) <- needsLayout
- \
- RenderBlock (generated content) <- needsLayout
- \
- RenderQuote <- needsLayout
--->
-
-<div class="positioned"></div>
-<div class="focusable" tabindex="1"></div>
-
-<script>
- if (window.testRunner)
- testRunner.dumpAsText();
- // .focusable still needs layout at this point, but RenderView doesn't
- // think any descendants need layout.
- document.querySelector('.focusable').focus();
-</script>

Powered by Google App Engine
This is Rietveld 408576698