LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html - Issue 12314017: Revert 143493

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-generated-content/quote-layout-focus-crash.html

Issue 12314017: Revert 143493 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1364/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2

3 <style>

4 /* Must be positioned absolute or static, must have margins to push it out v iew. */

5 .positioned {

6 position: absolute;

7 margin-top: 100%;

8 }

9

10 /* Any kind of quote will do, can be either :before or :after */

11 .positioned:before,

12 .focusable:before {

13 content: open-quote;

14 }

15 </style>

16

17 <p>Bug 109616 - ASSERT(!renderer()->needsLayout()) when calling Element::focus() with generated content</p>

18

19 <!--

20 This is testing a case where RenderQuote::updateDepth will mark the RenderQu ote

21 and its ancestors as needing layout in the middle of a layout of its ancesto r.

22 When its ancestor finishes the layout it will mark itself and the ancestors

23 farther up as no longer needing layout. The end result is some subtree

24 needing layout, but the RenderView and possibly other ancestors of the subtr ee

25 not needing layout.

26

27 ex.

28

29 RenderView <- !needsLayout

30 \

31 RenderBlock (.focusable) <- needsLayout

32 \

33 RenderBlock (generated content) <- needsLayout

34 \

35 RenderQuote <- needsLayout

36 -->

37

38 <div class="positioned"></div>

39 <div class="focusable" tabindex="1"></div>

40

41 <script>

42 if (window.testRunner)

43 testRunner.dumpAsText();

44 // .focusable still needs layout at this point, but RenderView doesn't

45 // think any descendants need layout.

46 document.querySelector('.focusable').focus();

47 </script>

OLD	NEW