Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 12314014: CMake generator. (Closed)

Created:
7 years, 10 months ago by bungeman-chromium
Modified:
7 years, 1 month ago
Reviewers:
Nico, Sam Clegg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

CMake generator. Designed to create projects for IDEs like kdevelop, qtcreator, code::blocks, or eclipse cdt. Generated CMakeLists.txt can also be used to build (currently limited to *nix). Requires CMake 2.8.8 or later. With patch set 9 (which builds CMake 2.8.8 on the bot) passes tests on the bots. R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1796

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Handle #

Patch Set 6 : Add inputs to Actions, Rules, and Copies as IDE displayable sources. #

Patch Set 7 : #

Patch Set 8 : Write include dirs to variable. #

Patch Set 9 : #

Patch Set 10 : Update build change since scons has been removed. #

Patch Set 11 : Correct bad merge of buildbot_run.py. #

Patch Set 12 : #

Patch Set 13 : Update to current, pass new tests. #

Patch Set 14 : Put built cmake first on path. #

Patch Set 15 : Cleaner status munging. #

Total comments: 33

Patch Set 16 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1343 lines, -23 lines) Patch
M buildbot/buildbot_run.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +42 lines, -0 lines 0 comments Download
M gyptest.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
A pylib/gyp/generator/cmake.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1150 lines, -0 lines 0 comments Download
M test/additional-targets/gyptest-additional.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M test/builddir/gyptest-all.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -3 lines 0 comments Download
M test/builddir/gyptest-default.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -3 lines 0 comments Download
M test/defines/gyptest-define-override.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +12 lines, -3 lines 0 comments Download
M test/defines/gyptest-defines.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +15 lines, -3 lines 0 comments Download
M test/generator-output/gyptest-copies.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +3 lines, -4 lines 0 comments Download
M test/lib/TestGyp.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +105 lines, -0 lines 0 comments Download
M test/no-cpp/gyptest-no-cpp.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M test/prune_targets/gyptest-prune-targets.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M test/sibling/gyptest-all.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M test/sibling/gyptest-relocate.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M test/standalone-static-library/gyptest-standalone-static-library.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -1 line 0 comments Download
M test/subdirectory/gyptest-subdir-all.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -1 line 0 comments Download
M test/subdirectory/gyptest-subdir-default.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
bungeman-chromium
This is a continuation of https://codereview.appspot.com/5996048/ .
7 years, 10 months ago (2013-02-20 16:24:13 UTC) #1
bungeman-chromium
Fixed some pylint.
7 years, 10 months ago (2013-02-20 20:43:09 UTC) #2
bungeman-chromium
Patch Set 3 puts inputs common to all rule commands into a variable and references ...
7 years, 9 months ago (2013-02-28 04:24:25 UTC) #3
bungeman-chromium
Patch Set 4 keeps all shared objects out of --start-group --end-group. This prevents more places ...
7 years, 9 months ago (2013-02-28 19:34:53 UTC) #4
bungeman-chromium
Patch Set 5 handles toplevel_dir like ninja. This gives relative paths when the gyp file ...
7 years, 9 months ago (2013-02-28 23:43:12 UTC) #5
bungeman-chromium
With Patch Set 6, inputs to Actions, Rules, and Copies are specified as informative sources ...
7 years, 9 months ago (2013-03-04 19:07:24 UTC) #6
bungeman-chromium
Just wanted to point out that after Patch Set 5 this generator is now much ...
7 years, 9 months ago (2013-03-06 22:38:05 UTC) #7
bungeman-chromium
With Patch set 7, 'GYP_GENERATORS=ninja,cmake' works and places the CMakeLists.txt in the correct place no ...
7 years, 9 months ago (2013-03-18 16:04:07 UTC) #8
Evan Martin
I'm really curious how gyp -> ninja differs from gyp -> cmake -> ninja.
7 years, 9 months ago (2013-03-18 16:47:11 UTC) #9
bungeman-chromium
On 2013/03/18 16:47:11, Evan Martin wrote: > I'm really curious how gyp -> ninja differs ...
7 years, 9 months ago (2013-03-18 17:03:35 UTC) #10
bungeman-chromium
Patch Set 8 is a small change to write the include directories out to a ...
7 years, 8 months ago (2013-04-01 21:47:13 UTC) #11
bungeman-chromium
Patch Set 9 adds the CMake generator to the tests by pulling a shallow clone ...
7 years, 8 months ago (2013-04-03 23:08:45 UTC) #12
bungeman-chromium
Updated to apply cleanly against current.
7 years, 8 months ago (2013-04-18 18:44:08 UTC) #13
bungeman-chromium
This is now (at patch set 15) once again passing tests, has a few users, ...
7 years, 1 month ago (2013-11-18 01:35:37 UTC) #14
Nico
Thanks for the ping! Basically lgtm, a few stylistic issues below (consistent function naming, and ...
7 years, 1 month ago (2013-11-19 16:35:28 UTC) #15
bungeman-chromium
Addressed comments. https://codereview.chromium.org/12314014/diff/251001/pylib/gyp/generator/cmake.py File pylib/gyp/generator/cmake.py (right): https://codereview.chromium.org/12314014/diff/251001/pylib/gyp/generator/cmake.py#newcode1 pylib/gyp/generator/cmake.py:1: # Copyright (c) 2012 Google Inc. All ...
7 years, 1 month ago (2013-11-20 20:54:51 UTC) #16
bungeman-chromium
7 years, 1 month ago (2013-11-20 22:31:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #16 manually as r1796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698