Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/sibling/gyptest-all.py

Issue 12314014: CMake generator. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Address comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/prune_targets/gyptest-prune-targets.py ('k') | test/sibling/gyptest-relocate.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/sibling/gyptest-all.py
===================================================================
--- test/sibling/gyptest-all.py (revision 1794)
+++ test/sibling/gyptest-all.py (working copy)
@@ -21,7 +21,7 @@
# TODO(mmoss) Should the Makefile go in the directory of the passed in .gyp
# file? What about when passing in multiple .gyp files? Would sub-project
# Makefiles (see http://codereview.chromium.org/340008 comments) solve this?
-if test.format in ('make', 'ninja'):
+if test.format in ('make', 'ninja', 'cmake'):
chdir = 'src'
if test.format == 'xcode':
« no previous file with comments | « test/prune_targets/gyptest-prune-targets.py ('k') | test/sibling/gyptest-relocate.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698