Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1231273003: Refresh Frame(Loader) detach() related comments. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
haraken, Nate Chapin, dcheng
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refresh Frame(Loader) detach() related comments. Update comments not to refer the older detachFromParent(). R=haraken,dcheng BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198804

Patch Set 1 #

Total comments: 2

Patch Set 2 : improve wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M Source/core/frame/FrameView.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
The older detachFromParent() is no more, update&sync various comments; clearer & worth doing?
5 years, 5 months ago (2015-07-13 06:51:25 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-13 07:10:28 UTC) #3
dcheng
lgtm https://codereview.chromium.org/1231273003/diff/1/Source/core/frame/FrameView.h File Source/core/frame/FrameView.h (right): https://codereview.chromium.org/1231273003/diff/1/Source/core/frame/FrameView.h#newcode727 Source/core/frame/FrameView.h:727: // when a LocalFrame is detached (LocalFrame::detach()). Personally, ...
5 years, 5 months ago (2015-07-13 17:27:51 UTC) #4
sof
On 2015/07/13 17:27:51, dcheng wrote: > lgtm > Thanks for the careful readthrough; comments taken ...
5 years, 5 months ago (2015-07-13 19:25:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231273003/20001
5 years, 5 months ago (2015-07-13 19:26:18 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 19:31:03 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198804

Powered by Google App Engine
This is Rietveld 408576698