Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1231273003: Refresh Frame(Loader) detach() related comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | Source/web/WebLocalFrameImpl.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 706 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 717
718 LayoutSize m_size; 718 LayoutSize m_size;
719 719
720 typedef HashSet<RefPtr<LayoutEmbeddedObject>> EmbeddedObjectSet; 720 typedef HashSet<RefPtr<LayoutEmbeddedObject>> EmbeddedObjectSet;
721 EmbeddedObjectSet m_partUpdateSet; 721 EmbeddedObjectSet m_partUpdateSet;
722 722
723 // FIXME: These are just "children" of the FrameView and should be RefPtrWil lBeMember<Widget> instead. 723 // FIXME: These are just "children" of the FrameView and should be RefPtrWil lBeMember<Widget> instead.
724 HashSet<RefPtr<LayoutPart>> m_parts; 724 HashSet<RefPtr<LayoutPart>> m_parts;
725 725
726 // The RefPtr cycle between LocalFrame and FrameView is broken 726 // The RefPtr cycle between LocalFrame and FrameView is broken
727 // when a LocalFrame is detached by FrameLoader::detachFromParent(). 727 // when a LocalFrame is detached (LocalFrame::detach()).
dcheng 2015/07/13 17:27:51 Personally, I think 'by' is a bit clearer since it
728 // It clears the LocalFrame's m_view reference via setView(nullptr). 728 // It clears the LocalFrame's m_view reference via setView(nullptr).
729 // 729 //
730 // For Oilpan, Member reference cycles pose no problem, but 730 // For Oilpan, Member reference cycles pose no problem, but
731 // LocalFrame's FrameView is also cleared by setView(). This additionally 731 // LocalFrame's FrameView is also cleared by setView() to keep
732 // triggers FrameView::dispose(), which performs the operations 732 // the observable lifespan of LocalFrame::view() identical.
733 // that cannot be delayed until finalization time.
734 RefPtrWillBeMember<LocalFrame> m_frame; 733 RefPtrWillBeMember<LocalFrame> m_frame;
735 734
736 WebDisplayMode m_displayMode; 735 WebDisplayMode m_displayMode;
737 736
738 bool m_doFullPaintInvalidation; 737 bool m_doFullPaintInvalidation;
739 738
740 bool m_canHaveScrollbars; 739 bool m_canHaveScrollbars;
741 unsigned m_slowRepaintObjectCount; 740 unsigned m_slowRepaintObjectCount;
742 741
743 bool m_hasPendingLayout; 742 bool m_hasPendingLayout;
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
865 static const unsigned visualPixelThreshold = 32 * 32; 864 static const unsigned visualPixelThreshold = 32 * 32;
866 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 865 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
867 setIsVisuallyNonEmpty(); 866 setIsVisuallyNonEmpty();
868 } 867 }
869 868
870 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 869 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
871 870
872 } // namespace blink 871 } // namespace blink
873 872
874 #endif // FrameView_h 873 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | Source/web/WebLocalFrameImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698