Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1231273002: Fix framebuffer completeness ES3 behavior. (Closed)

Created:
5 years, 5 months ago by Zhenyao Mo
Modified:
5 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), bajones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix framebuffer completeness ES3 behavior. In ES3, dimensions of images are no longer required to match. BUG=429053 TEST=gpu_unittests, webgl_conformance2 R=piman@chromium.org Committed: https://crrev.com/a0ee95ed8a530ebd2ee428162fa80ba47e72802c Cr-Commit-Position: refs/heads/master@{#338420}

Patch Set 1 #

Patch Set 2 : add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -16 lines) Patch
M gpu/command_buffer/service/context_group.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 4 chunks +9 lines, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 1 6 chunks +63 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Zhenyao Mo
PTAL
5 years, 5 months ago (2015-07-10 23:50:39 UTC) #1
Zhenyao Mo
With this CL, conformance2/renderbuffers/framebuffer-object-attachment.html should pass
5 years, 5 months ago (2015-07-10 23:51:10 UTC) #2
piman
LGTM, but can you add a test case for WEBGL2 contexts?
5 years, 5 months ago (2015-07-10 23:58:12 UTC) #3
Zhenyao Mo
Added a unit test. Do you wanna take another look?
5 years, 5 months ago (2015-07-11 00:28:46 UTC) #4
piman
lgtm
5 years, 5 months ago (2015-07-11 00:36:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231273002/20001
5 years, 5 months ago (2015-07-11 00:47:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-11 01:33:20 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 01:34:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0ee95ed8a530ebd2ee428162fa80ba47e72802c
Cr-Commit-Position: refs/heads/master@{#338420}

Powered by Google App Engine
This is Rietveld 408576698