Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: gpu/command_buffer/service/context_group.cc

Issue 1231273002: Fix framebuffer completeness ES3 behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add unittest Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/context_group.h" 5 #include "gpu/command_buffer/service/context_group.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 if (max_color_attachments_ < 1) 147 if (max_color_attachments_ < 1)
148 max_color_attachments_ = 1; 148 max_color_attachments_ = 1;
149 GetIntegerv(GL_MAX_DRAW_BUFFERS_ARB, &max_draw_buffers_); 149 GetIntegerv(GL_MAX_DRAW_BUFFERS_ARB, &max_draw_buffers_);
150 if (max_draw_buffers_ < 1) 150 if (max_draw_buffers_ < 1)
151 max_draw_buffers_ = 1; 151 max_draw_buffers_ = 1;
152 draw_buffer_ = GL_BACK; 152 draw_buffer_ = GL_BACK;
153 } 153 }
154 154
155 buffer_manager_.reset( 155 buffer_manager_.reset(
156 new BufferManager(memory_tracker_.get(), feature_info_.get())); 156 new BufferManager(memory_tracker_.get(), feature_info_.get()));
157 framebuffer_manager_.reset( 157 framebuffer_manager_.reset(new FramebufferManager(
158 new FramebufferManager(max_draw_buffers_, max_color_attachments_)); 158 max_draw_buffers_, max_color_attachments_, context_type));
159 renderbuffer_manager_.reset(new RenderbufferManager( 159 renderbuffer_manager_.reset(new RenderbufferManager(
160 memory_tracker_.get(), max_renderbuffer_size, max_samples, 160 memory_tracker_.get(), max_renderbuffer_size, max_samples,
161 feature_info_.get())); 161 feature_info_.get()));
162 shader_manager_.reset(new ShaderManager()); 162 shader_manager_.reset(new ShaderManager());
163 valuebuffer_manager_.reset( 163 valuebuffer_manager_.reset(
164 new ValuebufferManager(subscription_ref_set_.get(), 164 new ValuebufferManager(subscription_ref_set_.get(),
165 pending_valuebuffer_state_.get())); 165 pending_valuebuffer_state_.get()));
166 166
167 // Lookup GL things we need to know. 167 // Lookup GL things we need to know.
168 const GLint kGLES2RequiredMinimumVertexAttribs = 8u; 168 const GLint kGLES2RequiredMinimumVertexAttribs = 8u;
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 GLuint client_id, GLuint* service_id) const { 445 GLuint client_id, GLuint* service_id) const {
446 Buffer* buffer = buffer_manager_->GetBuffer(client_id); 446 Buffer* buffer = buffer_manager_->GetBuffer(client_id);
447 if (!buffer) 447 if (!buffer)
448 return false; 448 return false;
449 *service_id = buffer->service_id(); 449 *service_id = buffer->service_id();
450 return true; 450 return true;
451 } 451 }
452 452
453 } // namespace gles2 453 } // namespace gles2
454 } // namespace gpu 454 } // namespace gpu
OLDNEW
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698