Share SyncPointManager between ipc and in-process

components/view_manager/gles2/command_buffer_impl.cc

Index: components/view_manager/gles2/command_buffer_impl.cc
diff --git a/components/view_manager/gles2/command_buffer_impl.cc b/components/view_manager/gles2/command_buffer_impl.cc
index 9a2a97b803d3fde10e24e7e00deb0eb0770bc64d..c46b4574a21ed63eaaf60492d5073c70bc97283b 100644
--- a/components/view_manager/gles2/command_buffer_impl.cc
+++ b/components/view_manager/gles2/command_buffer_impl.cc
@@ -108,15 +108,16 @@ void CommandBufferImpl::InsertSyncPoint(bool retire) {
   sync_point_client_->DidInsertSyncPoint(sync_point);
   if (retire) {
     driver_task_runner_->PostTask(
-        FROM_HERE, base::Bind(&gpu::SyncPointManager::RetireSyncPoint,
-                              sync_point_manager_, sync_point));
+        FROM_HERE,
+        base::Bind(&gpu::SyncPointManager::RetireSyncPoint,
+                   base::Unretained(sync_point_manager_), sync_point));

[msw, 2015/07/21 00:46:03]

What guarantees that |sync_point_manager_| exists when the callback is run?

[boliu, 2015/07/21 00:57:19]

Hmm, I'm not sure actually.

It outlives the "control thread", but I'm guessing driver_task_runner is not the
control thread. And I don't know mojo threads ordering/ownership etc at all..

One not very pretty option is to add a ref counted wrapper..

   }
 }
 
 void CommandBufferImpl::RetireSyncPoint(uint32_t sync_point) {
   driver_task_runner_->PostTask(
       FROM_HERE, base::Bind(&gpu::SyncPointManager::RetireSyncPoint,
-                            sync_point_manager_, sync_point));
+                            base::Unretained(sync_point_manager_), sync_point));
 }
 
 void CommandBufferImpl::Echo(const mojo::Callback<void()>& callback) {