Share SyncPointManager between ipc and in-process

components/view_manager/gles2/command_buffer_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/view_manager/gles2/command_buffer_impl.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "components/view_manager/gles2/command_buffer_driver.h"
 #include "components/view_manager/gles2/command_buffer_impl_observer.h"
@@ skipping 90 matching lines @@
   driver_task_runner_->PostTask(
       FROM_HERE, base::Bind(&CommandBufferDriver::DestroyTransferBuffer,
                             base::Unretained(driver_.get()), id));
 }
 
 void CommandBufferImpl::InsertSyncPoint(bool retire) {
   uint32_t sync_point = sync_point_manager_->GenerateSyncPoint();
   sync_point_client_->DidInsertSyncPoint(sync_point);
   if (retire) {
     driver_task_runner_->PostTask(
-        FROM_HERE, base::Bind(&gpu::SyncPointManager::RetireSyncPoint,
-                              sync_point_manager_, sync_point));
+        FROM_HERE,
+        base::Bind(&gpu::SyncPointManager::RetireSyncPoint,
+                   base::Unretained(sync_point_manager_), sync_point));

[msw, 2015/07/21 00:46:03]

What guarantees that |sync_point_manager_| exists when the callback is run?

[boliu, 2015/07/21 00:57:19]

Hmm, I'm not sure actually.

It outlives the "control thread", but I'm guessing driver_task_runner is not the
control thread. And I don't know mojo threads ordering/ownership etc at all..

One not very pretty option is to add a ref counted wrapper..

   }
 }
 
 void CommandBufferImpl::RetireSyncPoint(uint32_t sync_point) {
   driver_task_runner_->PostTask(
       FROM_HERE, base::Bind(&gpu::SyncPointManager::RetireSyncPoint,
-                            sync_point_manager_, sync_point));
+                            base::Unretained(sync_point_manager_), sync_point));
 }
 
 void CommandBufferImpl::Echo(const mojo::Callback<void()>& callback) {
   driver_task_runner_->PostTaskAndReply(FROM_HERE, base::Bind(&base::DoNothing),
                                         base::Bind(&RunCallback, callback));
 }
 
 void CommandBufferImpl::CreateImage(int32_t id,
                                     mojo::ScopedHandle memory_handle,
                                     int32 type,
@@ skipping 42 matching lines @@
 
 void CommandBufferImpl::UpdateVSyncParameters(base::TimeTicks timebase,
                                               base::TimeDelta interval) {
   if (!viewport_parameter_listener_)
     return;
   viewport_parameter_listener_->OnVSyncParametersUpdated(
       timebase.ToInternalValue(), interval.ToInternalValue());
 }
 
 }  // namespace gles2