Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: remoting/android/java/res/layout/vr_desktop.xml

Issue 1231153002: Add VR desktop activity structure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add vr desktop basic structure Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/res/layout/vr_desktop.xml
diff --git a/chromecast/browser/android/apk/res/layout/cast_shell_activity.xml b/remoting/android/java/res/layout/vr_desktop.xml
similarity index 53%
copy from chromecast/browser/android/apk/res/layout/cast_shell_activity.xml
copy to remoting/android/java/res/layout/vr_desktop.xml
index 428b1a512a6e70f697e1baceb6b50d6cb14d7d7b..c639e5aef7e1b6d2bd06058be9cc6edbadab1e40 100644
--- a/chromecast/browser/android/apk/res/layout/cast_shell_activity.xml
+++ b/remoting/android/java/res/layout/vr_desktop.xml
@@ -3,11 +3,13 @@
<!-- Copyright 2014 The Chromium Authors. All rights reserved.
Lambros 2015/07/10 22:25:03 2015
shichengfeng 2015/07/10 23:32:22 Done.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
- -->
+-->
-<merge xmlns:android="http://schemas.android.com/apk/res/android">
- <org.chromium.chromecast.shell.CastWindowManager
- android:id="@+id/shell_container"
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
Lambros 2015/07/10 22:25:03 You have only 1 child, so I think you can change t
shichengfeng 2015/07/10 23:32:22 Done.
+ android:layout_width="match_parent"
Lambros 2015/07/10 22:25:03 Use spaces instead of tab.
shichengfeng 2015/07/10 23:32:22 Done.
+ android:layout_height="match_parent" >
+ <com.google.vrtoolkit.cardboard.CardboardView
+ android:id="@+id/cardboard_view"
android:layout_width="match_parent"
android:layout_height="match_parent" />
-</merge>
+</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698