remoting/android/java/res/layout/vr_desktop.xml - Issue 1231153002: Add VR desktop activity structure

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/android/java/res/layout/vr_desktop.xml

Issue 1231153002: Add VR desktop activity structure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add vr desktop basic structure Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« remoting/android/java/AndroidManifest.xml.jinja2 ('K') | « remoting/android/java/AndroidManifest.xml.jinja2 ('k') | remoting/android/java/src/org/chromium/chromoting/VRDesktop.java » ('j') | remoting/android/java/src/org/chromium/chromoting/VRDesktop.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2	2

3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
	Lambros 2015/07/10 22:25:03 2015 2015 shichengfeng 2015/07/10 23:32:22 Done. Show quoted text On 2015/07/10 22:25:03, Lambros wrote: > 2015 Done.
4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <merge xmlns:android="http://schemas.android.com/apk/res/android">	8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
	Lambros 2015/07/10 22:25:03 You have only 1 child, so I think you can change t You have only 1 child, so I think you can change this RelativeLayout to <merge>. And then you don't need layout_width or layout_height here (though you still need them in the CardboardView). shichengfeng 2015/07/10 23:32:22 Done. Show quoted text On 2015/07/10 22:25:03, Lambros wrote: > You have only 1 child, so I think you can change this RelativeLayout to <merge>. > And then you don't need layout_width or layout_height here (though you still > need them in the CardboardView). Done.
9 <org.chromium.chromecast.shell.CastWindowManager	9 » android:layout_width="match_parent"
	Lambros 2015/07/10 22:25:03 Use spaces instead of tab. Use spaces instead of tab. shichengfeng 2015/07/10 23:32:22 Done. Show quoted text On 2015/07/10 22:25:03, Lambros wrote: > Use spaces instead of tab. Done.
10 android:id="@+id/shell_container"	10 » android:layout_height="match_parent" >

	11 <com.google.vrtoolkit.cardboard.CardboardView

	12 android:id="@+id/cardboard_view"

11 android:layout_width="match_parent"	13 android:layout_width="match_parent"

12 android:layout_height="match_parent" />	14 android:layout_height="match_parent" />

13 </merge>	15 </RelativeLayout>

OLD	NEW