Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1231103005: Rename watchPerformance to watch (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename watchPerformance to watch Now that we don't have the old animation system, we can use the shorter name again. Also, move state initialization code into initState(). R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7c89f2985f24249f24ecc0edf8b8d71cc5a35317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -146 lines) Patch
M sky/sdk/example/stocks/lib/stock_home.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/lib/widgets/animated_container.dart View 1 chunk +0 lines, -121 lines 0 comments Download
M sky/sdk/lib/widgets/dismissable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/toggleable.dart View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-14 00:15:47 UTC) #1
Hixie
lgtm
5 years, 5 months ago (2015-07-14 00:17:32 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-07-14 00:17:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c89f2985f24249f24ecc0edf8b8d71cc5a35317 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698