Issue 12310063: Add TestTimelineFrames and TestPageOverlayUpdate tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12310063: Add TestTimelineFrames and TestPageOverlayUpdate tests. (Closed)

Created:
7 years, 10 months ago by caseq

Modified:
4 years, 7 months ago

Reviewers:
not_yurys, yurys

CC:
chromium-reviews, yurys, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add TestTimelineFrames and TestPageOverlayUpdate tests. BUG=webk.it/110592 & webk.it/97567 TEST=yes

Patch Set 2 : Added missing new file #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	chrome/browser/devtools/devtools_sanity_browsertest.cc	View		2 chunks	+13 lines, -0 lines	1 comment	Download
	A	chrome/test/data/devtools/animation_frames_page.html	View	1	1 chunk	+33 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/12310063/diff/3001/chrome/browser/devtools/devtools_sanity_browsertest.cc File chrome/browser/devtools/devtools_sanity_browsertest.cc (right): https://codereview.chromium.org/12310063/diff/3001/chrome/browser/devtools/devtools_sanity_browsertest.cc#newcode601 chrome/browser/devtools/devtools_sanity_browsertest.cc:601: Maybe add a comment for this test too ...

7 years, 10 months ago (2013-02-25 09:13:48 UTC) #2

ping

Expand Messages | Collapse Messages

Issue 12310063: Add TestTimelineFrames and TestPageOverlayUpdate tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added missing new file #

Messages