Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 12310063: Add TestTimelineFrames and TestPageOverlayUpdate tests. (Closed)

Created:
7 years, 10 months ago by caseq
Modified:
4 years, 7 months ago
Reviewers:
not_yurys, yurys
CC:
chromium-reviews, yurys, pfeldman
Visibility:
Public.

Description

Add TestTimelineFrames and TestPageOverlayUpdate tests. BUG=webk.it/110592 & webk.it/97567 TEST=yes

Patch Set 1 #

Patch Set 2 : Added missing new file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +13 lines, -0 lines 1 comment Download
A chrome/test/data/devtools/animation_frames_page.html View 1 1 chunk +33 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
caseq
7 years, 10 months ago (2013-02-22 13:17:36 UTC) #1
yurys
lgtm https://codereview.chromium.org/12310063/diff/3001/chrome/browser/devtools/devtools_sanity_browsertest.cc File chrome/browser/devtools/devtools_sanity_browsertest.cc (right): https://codereview.chromium.org/12310063/diff/3001/chrome/browser/devtools/devtools_sanity_browsertest.cc#newcode601 chrome/browser/devtools/devtools_sanity_browsertest.cc:601: Maybe add a comment for this test too ...
7 years, 10 months ago (2013-02-25 09:13:48 UTC) #2
yurys
Has this been landed? if so we should close the issue
7 years, 7 months ago (2013-05-16 19:54:34 UTC) #3
vsevik
6 years, 9 months ago (2014-03-13 10:31:20 UTC) #4
ping

Powered by Google App Engine
This is Rietveld 408576698