gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index 724d537d7a7039de659aeba7ab542f7532ed7765..d903ea344805d56e352aaa5f4e8425988b6782f0 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -4022,6 +4022,7 @@ void GLES2DecoderImpl::DoDiscardFramebufferEXT(GLenum target,

break;

case GL_DEPTH_EXT:

backbuffer_needs_clear_bits_ |= GL_DEPTH_BUFFER_BIT;

+ break; // FIXME is this right

case GL_STENCIL_EXT:

backbuffer_needs_clear_bits_ |= GL_STENCIL_BUFFER_BIT;

break;

@@ -5065,6 +5066,7 @@ void GLES2DecoderImpl::DoGetRenderbufferParameteriv(

glGetRenderbufferParameterivEXT(target, GL_RENDERBUFFER_SAMPLES_EXT,

params);

}

+ break; // FIXME is this right

default:

glGetRenderbufferParameterivEXT(target, pname, params);

break;

« no previous file with comments | « google_apis/gaia/oauth_request_signer.cc ('k') | gpu/config/gpu_info_collector_mac.mm » ('j') | no next file with comments »