google_apis/gaia/oauth_request_signer.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/oauth_request_signer.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/oauth_request_signer.cc

diff --git a/google_apis/gaia/oauth_request_signer.cc b/google_apis/gaia/oauth_request_signer.cc

index 115c14d6f01f8c1f8ed43f4956abfa4d8af8daa3..519cab72ea331f6ea598a9ca7cd5d34199a88136 100644

--- a/google_apis/gaia/oauth_request_signer.cc

+++ b/google_apis/gaia/oauth_request_signer.cc

@@ -409,7 +409,7 @@ bool OAuthRequestSigner::SignURL(

switch (http_method) {

case GET_METHOD:

signed_text = request_base_url.spec() + '?';

- // Intentionally falling through

+ FALLTHROUGH_INTENDED;

case POST_METHOD:

signed_text += BuildBaseStringParameters(parameters);

break;