content/common/gpu/client/gl_helper_scaling.cc - Issue 12310041: experiment with -Wimplicit-fallthrough

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gl_helper_scaling.cc

Issue 12310041: experiment with -Wimplicit-fallthrough Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/client/gl_helper_scaling.cc

diff --git a/content/common/gpu/client/gl_helper_scaling.cc b/content/common/gpu/client/gl_helper_scaling.cc

index ff6a6b7c8558d6c16d0f87ffff94bcc3a2a6cdc3..e45a926afe344ea4351efe0a777c681de435b4d6 100644

--- a/content/common/gpu/client/gl_helper_scaling.cc

+++ b/content/common/gpu/client/gl_helper_scaling.cc

@@ -367,6 +367,7 @@ void GLHelperScaling::ConvertScalerOpsToScalerStages(

switch (x_ops->size()) {

case 0:

NOTREACHED();

+ FALLTHROUGH_INTENDED;

case 1:

if (x_ops->front().scale_factor == 3) {

current_shader = SHADER_BILINEAR3;