ash/system/tray/tray_background_view.cc - Issue 12310022: More flexibility in BubbleBorder arrow rendering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/tray/tray_background_view.cc

Issue 12310022: More flexibility in BubbleBorder arrow rendering. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Now with more user choice: bool -> enum. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/tray/tray_background_view.cc

diff --git a/ash/system/tray/tray_background_view.cc b/ash/system/tray/tray_background_view.cc

index f4c29071e48e15ca6d4d5d2ea2e0cf7c747e8aee..7d86d143b12c41d7849cbb5f254a124709fe3b81 100644

--- a/ash/system/tray/tray_background_view.cc

+++ b/ash/system/tray/tray_background_view.cc

@@ -388,7 +388,10 @@ void TrayBackgroundView::UpdateBubbleViewArrow(

bubble_view->GetWidget()->GetNativeView()->GetRootWindow();

ash::internal::ShelfLayoutManager* shelf =

ash::GetRootWindowController(root_window)->shelf();

- bubble_view->SetPaintArrow(shelf->IsVisible());

+ if (shelf->IsVisible())

msw 2013/02/21 07:29:29 nit: move the condition into the call as a ternary

dewittj 2013/02/21 19:13:57 Done.

+ bubble_view->SetArrowPaintType(views::BubbleBorder::PAINT_NORMAL);

+ else

+ bubble_view->SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);

}

} // namespace internal