Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: ash/system/tray/system_tray.cc

Issue 12310022: More flexibility in BubbleBorder arrow rendering. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Now with more user choice: bool -> enum. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/system/tray/tray_background_view.cc » ('j') | ash/system/tray/tray_background_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/system_tray.cc
diff --git a/ash/system/tray/system_tray.cc b/ash/system/tray/system_tray.cc
index dba58c96b607dfceccf1023370f96755a245ca7a..9448859ec2410c5f29ab6730a8a7fb017759ce6f 100644
--- a/ash/system/tray/system_tray.cc
+++ b/ash/system/tray/system_tray.cc
@@ -375,7 +375,10 @@ void SystemTray::ShowItems(const std::vector<SystemTrayItem*>& items,
init_params.arrow_offset = arrow_offset;
// For Volume and Brightness we don't want to show an arrow when
// they are shown in a bubble by themselves.
- init_params.hide_arrow = items.size() == 1 && items[0]->ShouldHideArrow();
+ init_params.arrow_paint_type = views::BubbleBorder::PAINT_NORMAL;
+ if (items.size() == 1 && items[0]->ShouldHideArrow()) {
msw 2013/02/21 07:29:29 nit: remove braces.
dewittj 2013/02/21 19:13:57 Done. This is my Chromium style weakness. Sorry!
+ init_params.arrow_paint_type = views::BubbleBorder::PAINT_TRANSPARENT;
+ }
SystemTrayBubble* bubble = new SystemTrayBubble(this, items, bubble_type);
system_bubble_.reset(new internal::SystemBubbleWrapper(bubble));
system_bubble_->InitView(this, tray_container(), &init_params);
« no previous file with comments | « no previous file | ash/system/tray/tray_background_view.cc » ('j') | ash/system/tray/tray_background_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698