Switch all remaining android builders to ninja

Switch all remaining android builders to ninja

Remove make build logic and switch all bots to use ninja.
Many bots already use ninja to build, including
Android Builder (dbg) on main waterfall.

Also fix issue introduced in r154587 where experimental
compile did not use goma.

BUG=157947
R=Yaron

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183712

[Yaron, 2013-02-20 18:59:21]

Please also update envsetup.sh to default to ninja and add a warning if we
detect that your GYP_GENERATOR is make

https://codereview.chromium.org/12310007/diff/5001/build/android/buildbot/bui...
File build/android/buildbot/buildbot_functions.sh (right):

https://codereview.chromium.org/12310007/diff/5001/build/android/buildbot/bui...
build/android/buildbot/buildbot_functions.sh:114: ninja -C out/$BUILDTYPE -j1000
-l20 $TARGET
Why change the -j now?

[Isaac (away), 2013-02-21 00:09:18]

> Please also update envsetup.sh to default to
> ninja and add a warning if we detect that your
> GYP_GENERATOR is make

Done.  Please take another look!

https://chromiumcodereview.appspot.com/12310007/diff/5001/build/android/build...
File build/android/buildbot/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/12310007/diff/5001/build/android/build...
build/android/buildbot/buildbot_functions.sh:114: ninja -C out/$BUILDTYPE -j1000
-l20 $TARGET
On 2013/02/20 18:59:21, Yaron wrote:
> Why change the -j now?

didn't think it mattered.  I just took a look at compile.py (what the other
chromium bots use) and they use -j100 on line, so will leave it at 120.  Also
added back the GOMA_API_KEY variable, since compile.py also sets.

[Isaac (away), 2013-02-21 00:09:18]

> Please also update envsetup.sh to default to
> ninja and add a warning if we detect that your
> GYP_GENERATOR is make

Done.  Please take another look!

https://chromiumcodereview.appspot.com/12310007/diff/5001/build/android/build...
File build/android/buildbot/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/12310007/diff/5001/build/android/build...
build/android/buildbot/buildbot_functions.sh:114: ninja -C out/$BUILDTYPE -j1000
-l20 $TARGET
On 2013/02/20 18:59:21, Yaron wrote:
> Why change the -j now?

didn't think it mattered.  I just took a look at compile.py (what the other
chromium bots use) and they use -j100 on line, so will leave it at 120.  Also
added back the GOMA_API_KEY variable, since compile.py also sets.

[Yaron, 2013-02-21 00:19:37]

lgtm

Probably worth a PSA now to chromium-dev that dev workflow and bots default to
Ninja for android.

[Isaac (away), 2013-02-21 01:53:36]

Committed patchset #3 manually as r183712 (presubmit successful).