Switch all remaining android builders to ninja

build/android/buildbot/buildbot_functions.sh

 #!/bin/bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Bash functions used by buildbot annotator scripts for the android
 # build of chromium.  Executing this script should not perform actions
 # other than setting variables and defining of functions.
 
 # Number of jobs on the compile line; e.g.  make -j"${JOBS}"
@@ skipping 29 matching lines @@
 #   $2 and beyond: key value pairs which are parsed by bb_parse_args.
 function bb_baseline_setup {
   SRC_ROOT="$1"
   # Remove SRC_ROOT param
   shift
   cd $SRC_ROOT
 
   echo "@@@BUILD_STEP Environment setup@@@"
   bb_parse_args "$@"
 
-  local BUILDTOOL=$(bb_get_json_prop "$FACTORY_PROPERTIES" buildtool)
-  if [[ $BUILDTOOL = ninja ]]; then
-    export GYP_GENERATORS=ninja
-  fi
+  export GYP_GENERATORS=ninja
   export GOMA_DIR=/b/build/goma
   . build/android/envsetup.sh
 
   local extra_gyp_defines="$(bb_get_json_prop "$FACTORY_PROPERTIES" \
      extra_gyp_defines)"
   export GYP_DEFINES+=" fastbuild=1 $extra_gyp_defines"
   if echo $extra_gyp_defines | grep -qE 'clang|asan'; then
     unset CXX_target
   fi
 
@@ skipping 16 matching lines @@
     # crbug.com/145860
     rm -rf ~/.android
     rm -rf "$build_path"
     if [[ -e $build_path ]] ; then
       echo "Clobber appeared to fail?  $build_path still exists."
       echo "@@@STEP_WARNINGS@@@"
     fi
   fi
 }
 
-function bb_compile_setup {
-  bb_setup_goma_internal
-  # Should be called only after envsetup is done.
-  gclient runhooks
-}
-
 function bb_asan_tests_setup {
   # Download or build the ASan runtime library.
   ${SRC_ROOT}/tools/clang/scripts/update.sh
 }
 
 # Setup goma.  Used internally to buildbot_functions.sh.
 function bb_setup_goma_internal {
-  export GOMA_API_KEY_FILE=${GOMA_DIR}/goma.key
-  export GOMA_COMPILER_PROXY_DAEMON_MODE=true
-  export GOMA_COMPILER_PROXY_RPC_TIMEOUT_SECS=300
-
   echo "Killing old goma processes"
   ${GOMA_DIR}/goma_ctl.sh stop || true
   killall -9 compiler_proxy || true
 
   echo "Starting goma"
   ${GOMA_DIR}/goma_ctl.sh start
   trap bb_stop_goma_internal SIGHUP SIGINT SIGTERM
 }
 
 # Stop goma.
 function bb_stop_goma_internal {
   echo "Stopping goma"
   ${GOMA_DIR}/goma_ctl.sh stop
 }
 
-# $@: make args.
-# Use goma if possible; degrades to non-Goma if needed.
-function bb_goma_make {
-  if [ "${GOMA_DIR}" = "" ]; then
-    make -j${JOBS} "$@"
-    return
-  fi
-
-  HOST_CC=$GOMA_DIR/gcc
-  HOST_CXX=$GOMA_DIR/g++
-  TARGET_CC=$(/bin/ls $ANDROID_TOOLCHAIN/*-gcc | head -n1)
-  TARGET_CXX=$(/bin/ls $ANDROID_TOOLCHAIN/*-g++ | head -n1)
-  TARGET_CC="$GOMA_DIR/gomacc $TARGET_CC"
-  TARGET_CXX="$GOMA_DIR/gomacc $TARGET_CXX"
-  COMMON_JAVAC="$GOMA_DIR/gomacc /usr/bin/javac -J-Xmx512M \
-    -target 1.5 -Xmaxerrs 9999999"
-
-  command make \
-    -j100 \
-    -l20 \
-    HOST_CC="$HOST_CC" \
-    HOST_CXX="$HOST_CXX" \
-    TARGET_CC="$TARGET_CC" \
-    TARGET_CXX="$TARGET_CXX" \
-    CC.host="$HOST_CC" \
-    CXX.host="$HOST_CXX" \
-    CC.target="$TARGET_CC" \
-    CXX.target="$TARGET_CXX" \
-    LINK.target="$TARGET_CXX" \
-    COMMON_JAVAC="$COMMON_JAVAC" \
-    BUILDTYPE="$BUILDTYPE" \
-    "$@"
-
-  local make_exit_code=$?
-  return $make_exit_code
-}
-
 # Build using ninja.
 function bb_goma_ninja {
   echo "Using ninja to build."
   local TARGET=$1
-  ninja -C out/$BUILDTYPE -j120 -l20 $TARGET
+  bb_setup_goma_internal
+  ninja -C out/$BUILDTYPE -j1000 -l20 $TARGET

[Yaron, 2013/02/20 18:59:21]

Why change the -j now?

[Isaac (away), 2013/02/21 00:09:18]

didn't think it mattered.  I just took a look at compile.py (what the other
chromium bots use) and they use -j100 on line, so will leave it at 120.  Also
added back the GOMA_API_KEY variable, since compile.py also sets.

+  bb_stop_goma_internal
 }
 
 # Compile step
 function bb_compile {
-  # This must be named 'compile', not 'Compile', for CQ interaction.
-  # Talk to maruel for details.
+  # This must be named 'compile' for CQ.
   echo "@@@BUILD_STEP compile@@@"
-  bb_compile_setup
-
-  BUILDTOOL=$(bb_get_json_prop "$FACTORY_PROPERTIES" buildtool)
-  if [[ $BUILDTOOL = ninja ]]; then
-    bb_goma_ninja All
-  else
-    bb_goma_make
-  fi
-
-  bb_stop_goma_internal
+  gclient runhooks
+  bb_goma_ninja All
 }
 
 # Experimental compile step; does not turn the tree red if it fails.
 function bb_compile_experimental {
   # Linking DumpRenderTree appears to hang forever?
   EXPERIMENTAL_TARGETS="android_experimental"
   for target in ${EXPERIMENTAL_TARGETS} ; do
     echo "@@@BUILD_STEP Experimental Compile $target @@@"
     set +e
-    if [[ $BUILDTOOL = ninja ]]; then
-      bb_goma_ninja "${target}"
-    else
-      bb_goma_make -k "${target}"
-    fi
+    bb_goma_ninja "${target}"
     if [ $? -ne 0 ] ; then
       echo "@@@STEP_WARNINGS@@@"
     fi
     set -e
   done
 }
 
 # Run findbugs.
 function bb_run_findbugs {
   echo "@@@BUILD_STEP findbugs@@@"
@@ skipping 74 matching lines @@
   )
 }
 
 # Retrieve a packed json property using python
 function bb_get_json_prop {
   local JSON="$1"
   local PROP="$2"
 
   python -c "import json; print json.loads('$JSON').get('$PROP', '')"
 }