Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: test/cctest/test-api.cc

Issue 1230793002: [es6] silence access-check failure for well-known symbol properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ensure @@isConcatSpreadable is actually installed now that its in a separate list Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profiler/heap-snapshot-generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index a255183af051f0e9a5068920d97dc10f884e870d..74345e0676c2da355ab134f01fe8cf7c81e85870 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -21867,32 +21867,38 @@ TEST(EstimatedContextSize) {
}
-static int nb_uncaught_exception_callback_calls = 0;
-
-
-bool NoAbortOnUncaughtException(v8::Isolate* isolate) {
- ++nb_uncaught_exception_callback_calls;
- return false;
-}
-
-
-TEST(AbortOnUncaughtExceptionNoAbort) {
+TEST(AccessCheckedIsConcatSpreadable) {
+ i::FLAG_harmony_concat_spreadable = true;
v8::Isolate* isolate = CcTest::isolate();
- v8::HandleScope handle_scope(isolate);
- v8::Handle<v8::ObjectTemplate> global_template =
- v8::ObjectTemplate::New(isolate);
- LocalContext env(NULL, global_template);
-
- i::FLAG_abort_on_uncaught_exception = true;
- isolate->SetAbortOnUncaughtExceptionCallback(NoAbortOnUncaughtException);
-
- CompileRun("function boom() { throw new Error(\"boom\") }");
-
- v8::Local<v8::Object> global_object = env->Global();
- v8::Local<v8::Function> foo =
- v8::Local<v8::Function>::Cast(global_object->Get(v8_str("boom")));
+ HandleScope scope(isolate);
+ LocalContext env;
- foo->Call(global_object, 0, NULL);
+ // Object with access check
+ Local<ObjectTemplate> spreadable_template = v8::ObjectTemplate::New(isolate);
+ spreadable_template->SetAccessCheckCallbacks(AccessBlocker, nullptr);
+ spreadable_template->Set(v8::Symbol::GetIsConcatSpreadable(isolate),
+ v8::Boolean::New(isolate, true));
+ Local<Object> object = spreadable_template->NewInstance();
- CHECK_EQ(1, nb_uncaught_exception_callback_calls);
+ allowed_access = true;
+ env->Global()->Set(v8_str("object"), object);
+ object->Set(v8_str("length"), v8_num(2));
+ object->Set(0U, v8_str("a"));
+ object->Set(1U, v8_str("b"));
+
+ // Access check is allowed, and the object is spread
+ CompileRun("var result = [].concat(object)");
+ ExpectTrue("Array.isArray(result)");
+ ExpectString("result[0]", "a");
+ ExpectString("result[1]", "b");
+ ExpectTrue("result.length === 2");
+ ExpectTrue("object[Symbol.isConcatSpreadable]");
+
+ // If access check fails, the value of @@isConcatSpreadable is ignored
+ allowed_access = false;
+ CompileRun("var result = [].concat(object)");
+ ExpectTrue("Array.isArray(result)");
+ ExpectTrue("result[0] === object");
+ ExpectTrue("result.length === 1");
+ ExpectTrue("object[Symbol.isConcatSpreadable] === undefined");
}
« no previous file with comments | « src/profiler/heap-snapshot-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698