src/profiler/heap-snapshot-generator.cc - Issue 1230793002: [es6] silence access-check failure for well-known symbol properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/heap-snapshot-generator.cc

Issue 1230793002: [es6] silence access-check failure for well-known symbol properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Ensure @@isConcatSpreadable is actually installed now that its in a separate list Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/profiler/heap-snapshot-generator.cc

diff --git a/src/profiler/heap-snapshot-generator.cc b/src/profiler/heap-snapshot-generator.cc

index d29f3913fe9c581d467ca2f1f052352c16f5b408..75de3d6d1ab02563c999a5a3e2c1473cd92d41f5 100644

--- a/src/profiler/heap-snapshot-generator.cc

+++ b/src/profiler/heap-snapshot-generator.cc

@@ -2160,6 +2160,7 @@ const char* V8HeapExplorer::GetStrongGcSubrootName(Object* object) {

#undef SYMBOL_NAME

#define SYMBOL_NAME(name, description) NAME_ENTRY(name)

PUBLIC_SYMBOL_LIST(SYMBOL_NAME)

+ WELL_KNOWN_SYMBOL_LIST(SYMBOL_NAME)

#undef SYMBOL_NAME

#undef NAME_ENTRY

CHECK(!strong_gc_subroot_names_.is_empty());

« no previous file with comments | « src/objects-inl.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »