Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1230763008: The name argument for HTMLSelectElement namedItem() api should not be optional (Closed)

Created:
5 years, 5 months ago by shiva.jm
Modified:
5 years, 5 months ago
Reviewers:
tkent, philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

The name argument for HTMLSelectElement namedItem() api should not be optional As per spec link: https://html.spec.whatwg.org/#the-select-element, name argument for HTMLSelectElement namedItem() api should not be optional. Firefox and IE throws TypeError:Not enough arguments, if argument is missing. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198850

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M LayoutTests/fast/dom/HTMLSelectElement/exceptions.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLSelectElement/exceptions-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
shiva.jm
pls have a look.
5 years, 5 months ago (2015-07-14 08:34:04 UTC) #2
philipj_slow
On 2015/07/14 08:34:04, shiva.jm wrote: > pls have a look. LG, but needs a test.
5 years, 5 months ago (2015-07-14 08:43:29 UTC) #3
shiva.jm
added the test, pls have a look.
5 years, 5 months ago (2015-07-14 09:05:18 UTC) #4
philipj_slow
lgtm Thanks!
5 years, 5 months ago (2015-07-14 09:06:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230763008/20001
5 years, 5 months ago (2015-07-14 09:06:30 UTC) #7
philipj_slow
Unchecked CQ, please also add a tracking bug in case this needs to be reverted ...
5 years, 5 months ago (2015-07-14 09:08:44 UTC) #9
shiva.jm
On 2015/07/14 09:08:44, philipj wrote: > Unchecked CQ, please also add a tracking bug in ...
5 years, 5 months ago (2015-07-14 09:12:54 UTC) #10
shiva.jm
On 2015/07/14 09:12:54, shiva.jm wrote: > On 2015/07/14 09:08:44, philipj wrote: > > Unchecked CQ, ...
5 years, 5 months ago (2015-07-14 09:13:56 UTC) #11
philipj_slow
On 2015/07/14 09:13:56, shiva.jm wrote: > On 2015/07/14 09:12:54, shiva.jm wrote: > > On 2015/07/14 ...
5 years, 5 months ago (2015-07-14 09:28:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230763008/20001
5 years, 5 months ago (2015-07-14 09:28:36 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 10:04:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198850

Powered by Google App Engine
This is Rietveld 408576698