Source/core/html/HTMLSelectElement.idl - Issue 1230763008: The name argument for HTMLSelectElement namedItem() api should not be optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.idl

Issue 1230763008: The name argument for HTMLSelectElement namedItem() api should not be optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.idl

diff --git a/Source/core/html/HTMLSelectElement.idl b/Source/core/html/HTMLSelectElement.idl

index 718cec128d31644c7cd4058c927b22125298ab7c..c81347d2ae1489296df57b46b55eaa73eaee0237 100644

--- a/Source/core/html/HTMLSelectElement.idl

+++ b/Source/core/html/HTMLSelectElement.idl

@@ -37,8 +37,7 @@ interface HTMLSelectElement : HTMLElement {

// TODO(philipj): The length setter should never throw.

[RaisesException=Setter] attribute unsigned long length;

getter Element? item(unsigned long index);

- // TODO(philipj): The name argument should not be optional.

- HTMLOptionElement? namedItem([Default=Undefined] optional DOMString name);

+ HTMLOptionElement? namedItem(DOMString name);

[RaisesException, TypeChecking=Interface] void add((HTMLOptionElement or HTMLOptGroupElement) element,

optional (HTMLElement or long)? before = null);

[RaisesException] void remove(); // ChildNode overload

« no previous file with comments | « LayoutTests/fast/dom/HTMLSelectElement/exceptions-expected.txt ('k') | no next file » | no next file with comments »