Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230583002: Move protocol registration from WebViewClient to WebFrameClient, part 3/3. (Closed)

Created:
5 years, 5 months ago by Avi (use Gerrit)
Modified:
5 years, 5 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@protocol1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move protocol registration from WebViewClient to WebFrameClient, part 3/3. BUG=304341 TEST=protocol registration still works Committed: https://crrev.com/27f3df6a40d985dddfae6c06ceaf305a9203432c Cr-Commit-Position: refs/heads/master@{#338109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -13 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Depends on Patchset:

Issue 1228713003 Patch 1

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
Nasko, here's part 3; it's boring. Part 2 is the fun in Blink. https://codereview.chromium.org/1226113002/ , ...
5 years, 5 months ago (2015-07-08 21:41:41 UTC) #2
nasko
LGTM
5 years, 5 months ago (2015-07-09 12:32:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230583002/1
5 years, 5 months ago (2015-07-09 18:02:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 19:07:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 19:08:24 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/27f3df6a40d985dddfae6c06ceaf305a9203432c
Cr-Commit-Position: refs/heads/master@{#338109}

Powered by Google App Engine
This is Rietveld 408576698